This revision was automatically updated to reflect the committed changes.
Closed by commit rL323204: [clangd] Simplify code handling compile commands
(authored by ibiryukov, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D42173
Files:
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE323204: [clangd] Simplify code handling compile commands
(authored by ibiryukov, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D42173?vs=131062=131067#toc
Repository:
rL LLVM
ilya-biryukov marked an inline comment as done.
ilya-biryukov added inline comments.
Comment at: clangd/ClangdUnit.h:62
+/// Information required to run clang (e.g., to parse AST or do code
+/// completion).
+struct ParseInputs {
sammccall wrote:
> sammccall
ilya-biryukov updated this revision to Diff 131062.
ilya-biryukov marked 2 inline comments as done.
ilya-biryukov added a comment.
- Unwrap the comment
- Remove ParseInputs constructor
- Document the CppFile invariant
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D42173
Files:
sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
Comment at: clangd/ClangdUnit.h:62
+/// Information required to run clang (e.g., to parse AST or do code
+/// completion).
+struct ParseInputs {
ilya-biryukov updated this revision to Diff 130428.
ilya-biryukov marked 7 inline comments as done.
ilya-biryukov added a comment.
Herald added a subscriber: ioeric.
Addressing review comments
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D42173
Files:
ilya-biryukov added inline comments.
Comment at: clangd/ClangdServer.cpp:35
+tooling::CompileCommand getCompileCommand(GlobalCompilationDatabase ,
+ PathRef File, PathRef ResourceDir) {
sammccall wrote:
> This seems
sammccall added a comment.
This looks better overall to me.
I'm not sure about clangdserver rather than clangdunit computing the commands.
You're probably right but I'd like you to explain it to me :-)
Rest is just readability nits.
Comment at: clangd/ClangdServer.cpp:35
ilya-biryukov created this revision.
ilya-biryukov added reviewers: sammccall, bkramer.
Herald added a subscriber: klimek.
CppFile can now change compilation arguments during rebuild. This allows
simplifying code that manages CppFiles.
Repository:
rCTE Clang Tools Extra
