[PATCH] D42693: [libcxx] Handle invalid escaped characters in POSIX regex

2018-02-14 Thread Mikhail Maltsev via Phabricator via cfe-commits
miyuki added a comment. ping https://reviews.llvm.org/D42693 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D42693: [libcxx] Handle invalid escaped characters in POSIX regex

2018-02-01 Thread Mikhail Maltsev via Phabricator via cfe-commits
miyuki added inline comments. Comment at: include/regex:3490 { switch (*__temp) { mclow.lists wrote: > Do we need any more cases here? Probably not, but we should throw an exception here as well.

[PATCH] D42693: [libcxx] Handle invalid escaped characters in POSIX regex

2018-02-01 Thread Mikhail Maltsev via Phabricator via cfe-commits
miyuki updated this revision to Diff 132352. miyuki edited the summary of this revision. miyuki added a comment. Updated __parse_QUOTED_CHAR_ERE. Added more test cases. https://reviews.llvm.org/D42693 Files: include/regex test/std/re/re.regex/re.regex.construct/bad_escape.pass.cpp Index:

[PATCH] D42693: [libcxx] Handle invalid escaped characters in POSIX regex

2018-01-31 Thread Mikhail Maltsev via Phabricator via cfe-commits
miyuki added inline comments. Comment at: include/regex:3465 +case '{': +case '}': +break; Quuxplusone wrote: > FWIW, I don't understand what's going on in this switch. > Is it intentional that `'('` and `'|'` now take

[PATCH] D42693: [libcxx] Handle invalid escaped characters in POSIX regex

2018-01-30 Thread Arthur O'Dwyer via Phabricator via cfe-commits
Quuxplusone added inline comments. Comment at: include/regex:3465 +case '{': +case '}': +break; FWIW, I don't understand what's going on in this switch. Is it intentional that `'('` and `'|'` now take different paths here?

[PATCH] D42693: [libcxx] Handle invalid escaped characters in POSIX regex

2018-01-30 Thread Marshall Clow via Phabricator via cfe-commits
mclow.lists added a comment. I like this. One nit and a question. Comment at: include/regex:3490 { switch (*__temp) { Do we need any more cases here? Comment at:

[PATCH] D42693: [libcxx] Handle invalid escaped characters in POSIX regex

2018-01-30 Thread Mikhail Maltsev via Phabricator via cfe-commits
miyuki created this revision. miyuki added reviewers: EricWF, mclow.lists. Currently when parsing basic POSIX regular expressions libc++ silently skips invalid escaped characters and trailing escapes. This patch changes the behavior, so that a std::regex_error with code set to error_escape is