This revision was automatically updated to reflect the committed changes.
Closed by commit rL324802: [analyzer] NFC: Assert that our fix for noreturn
destructors keeps working. (authored by dergachev, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://revi
NoQ updated this revision to Diff 133675.
NoQ marked an inline comment as done.
NoQ added a comment.
Add the comment.
https://reviews.llvm.org/D42779
Files:
lib/StaticAnalyzer/Core/ExprEngineCXX.cpp
Index: lib/StaticAnalyzer/Core/ExprEngineCXX.cpp
===
dcoughlin accepted this revision.
dcoughlin added a comment.
This revision is now accepted and ready to land.
This looks good to me, but I think you should include your explanatory comments
in the commit message to the comment itself to help future violators of the
assertion out!
NoQ updated this revision to Diff 132316.
NoQ added a comment.
Add a comment explaining that it's not really bad to inline the constructor,
but we simply have the sink not implemented in this case.
https://reviews.llvm.org/D42779
Files:
lib/StaticAnalyzer/Core/ExprEngineCXX.cpp
Index: lib/
NoQ created this revision.
NoQ added a reviewer: dcoughlin.
Herald added subscribers: cfe-commits, a.sidorin, szepet, xazax.hun.
Herald added a reviewer: george.karpenkov.
Because we're planning to add more cases when temporary constructors will be
inlined, it is important to document the fact th
