[PATCH] D42863: Make __has_unique_object_representations reject empty union types.

2018-02-02 Thread Eric Fiselier via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL324134: Make __has_unique_object_representations reject empty union types. (authored by EricWF, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D42863: Make __has_unique_object_representations reject empty union types.

2018-02-02 Thread Eric Fiselier via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC324134: Make __has_unique_object_representations reject empty union types. (authored by EricWF, committed by ). Repository: rL LLVM https://reviews.llvm.org/D42863 Files: lib/AST/ASTContext.cpp

[PATCH] D42863: Make __has_unique_object_representations reject empty union types.

2018-02-02 Thread Erich Keane via Phabricator via cfe-commits
erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. Yep, LGTM, thanks! https://reviews.llvm.org/D42863 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D42863: Make __has_unique_object_representations reject empty union types.

2018-02-02 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF created this revision. EricWF added reviewers: erichkeane, rsmith, aaron.ballman, majnemer. Clang incorrectly reports empty unions as having a unique object representation. However, this is not correct since `sizeof(EmptyUnion) == 1` AKA it has 8 bits of padding. Therefore it should be