CarlosAlbertoEnciso added a comment.
@Typz,
It seems that the changes done to `ClangFormatStyleOptions.rst` @334408 are
causing the generation of the documentation to fail, with the following error:
Warning, treated as error:
/llvm/tools/clang/docs/ClangFormatStyleOptions.rst:1060:
This revision was automatically updated to reflect the committed changes.
Closed by commit rC334408: clang-format: Introduce BreakInheritanceList option
(authored by Typz, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D43015?vs=150755=150756#toc
Repository:
rC Clang
Typz updated this revision to Diff 150755.
Typz added a comment.
rebase
Repository:
rC Clang
https://reviews.llvm.org/D43015
Files:
docs/ClangFormatStyleOptions.rst
include/clang/Format/Format.h
lib/Format/ContinuationIndenter.cpp
lib/Format/Format.cpp
djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.
Looks good. Sorry for the delay.
Repository:
rC Clang
https://reviews.llvm.org/D43015
___
cfe-commits mailing list
Typz added a comment.
ping?
Repository:
rC Clang
https://reviews.llvm.org/D43015
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Typz added a comment.
ping?
Repository:
rC Clang
https://reviews.llvm.org/D43015
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Typz updated this revision to Diff 147011.
Typz added a comment.
Rebase on latest master
Repository:
rC Clang
https://reviews.llvm.org/D43015
Files:
docs/ClangFormatStyleOptions.rst
include/clang/Format/Format.h
lib/Format/ContinuationIndenter.cpp
lib/Format/Format.cpp
Typz added a comment.
@djasper : ping?
Repository:
rC Clang
https://reviews.llvm.org/D43015
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Typz added a comment.
ping?
Repository:
rC Clang
https://reviews.llvm.org/D43015
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Typz added a comment.
ping?
Repository:
rC Clang
https://reviews.llvm.org/D43015
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Typz added a comment.
ping?
Repository:
rC Clang
https://reviews.llvm.org/D43015
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Typz updated this revision to Diff 136306.
Typz added a comment.
Address review comments of https://reviews.llvm.org/D32525
Repository:
rC Clang
https://reviews.llvm.org/D43015
Files:
docs/ClangFormatStyleOptions.rst
include/clang/Format/Format.h
lib/Format/ContinuationIndenter.cpp
Typz updated this revision to Diff 136300.
Typz marked an inline comment as done.
Typz added a comment.
Address review comments, and rebase on https://reviews.llvm.org/D32525
Repository:
rC Clang
https://reviews.llvm.org/D43015
Files:
docs/ClangFormatStyleOptions.rst
djasper added a comment.
If both this and https://reviews.llvm.org/D32525 are submitted, then we also
need more tests for the combination of the two parameters.
Comment at: include/clang/Format/Format.h:852
+ /// \brief Different ways to break inheritance list.
+ enum
Typz added a comment.
ping?
Repository:
rC Clang
https://reviews.llvm.org/D43015
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Typz updated this revision to Diff 133204.
Typz added a comment.
Fix indentation of inheritance list, which is actually based on
`ConstructorInitializerIndentWidth`.
Maybe a new option (`InheritanceListIndentWidth`) should be used instead?
Repository:
rC Clang
Typz created this revision.
Typz added reviewers: djasper, krasimir, klimek.
This option replaces the BreakBeforeInheritanceComma option with an
enum, thus introducing a mode where the colon stays on the same line as
constructor declaration:
// When it fits on line:
class A : public B,
17 matches
Mail list logo
