This revision was automatically updated to reflect the committed changes.
Closed by commit rL325476: [clangd] Fix use-after-free in SymbolYAML: strings
are owned by yaml::Input! (authored by sammccall, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
ioeric accepted this revision.
ioeric added a comment.
This revision is now accepted and ready to land.
Thanks a lot for the fix!
Suggest a test case which reproduced the bug:
// comment with 'quote'
void f() {}
`runSymbolCollector` -> `SymbolToYAML` -> `SymbolFromYAML` -> check
sammccall created this revision.
sammccall added a reviewer: ioeric.
Herald added subscribers: cfe-commits, jkorous-apple, ilya-biryukov, klimek.
There are a few implementation options here - alternatives are either both
awkward and inefficient, or really inefficient.
This is at least potentially
