[PATCH] D43540: [WebAssembly] Enable -Werror=strict-prototypes by default

2019-01-10 Thread Dan Gohman via Phabricator via cfe-commits
sunfish added a comment. With https://reviews.llvm.org/D48471 and related work, it's not less urgent to do this. And since there were objections to having target-specific warnings anyway, let's close this. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D43540/new/

[PATCH] D43540: [WebAssembly] Enable -Werror=strict-prototypes by default

2018-02-20 Thread Eli Friedman via Phabricator via cfe-commits
efriedma added a comment. If someone is compiling C code that doesn't have undefined behavior, it should work; if it doesn't, that's a clear bug. (As far as I know, there shouldn't be any issues here, but if there are, file a bug and CC me.) WebAssembly is not the only platform where varargs

[PATCH] D43540: [WebAssembly] Enable -Werror=strict-prototypes by default

2018-02-20 Thread Sam Clegg via Phabricator via cfe-commits
sbc100 added a comment. Hmm.. actually this is probably going to break the waterfall pretty badly. But maybe we can fix it by re-disabling this explicitly when we build the gcc tests. Repository: rL LLVM https://reviews.llvm.org/D43540 ___

[PATCH] D43540: [WebAssembly] Enable -Werror=strict-prototypes by default

2018-02-20 Thread Sam Clegg via Phabricator via cfe-commits
sbc100 accepted this revision. sbc100 added a comment. This revision is now accepted and ready to land. Might want to line wrap your change description. Repository: rL LLVM https://reviews.llvm.org/D43540 ___ cfe-commits mailing list

[PATCH] D43540: [WebAssembly] Enable -Werror=strict-prototypes by default

2018-02-20 Thread Dan Gohman via Phabricator via cfe-commits
sunfish created this revision. sunfish added a reviewer: sbc100. Herald added subscribers: llvm-commits, aheejin, jfb. WebAssembly, the architecture, is not designed to support unprototyped calling conventions. For example, clang tends to assume that it can use varargs to implement parts of the