compnerd closed this revision.
compnerd added a comment.
SVN r325724
Repository:
rC Clang
https://reviews.llvm.org/D43586
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
I hate `inalloca` so much. Okay.
Repository:
rC Clang
https://reviews.llvm.org/D43586
___
cfe-commits mailing list
smeenai added a comment.
Patch is missing context.
Comment at: lib/CodeGen/CGDecl.cpp:1851
// The only implicit argument a block has is its literal.
// We assume this is always passed directly.
if (BlockInfo) {
This comment needs to be updated.
compnerd created this revision.
compnerd added a reviewer: rnk.
Herald added a subscriber: cfe-commits.
When using blocks with C++ on Windows x86, it is possible to have the
block literal be pushed into the inalloca'ed parameters. Teach IRGen to
handle the case properly by extracting the block
compnerd updated this revision to Diff 135304.
compnerd added a comment.
Update comment
Repository:
rC Clang
https://reviews.llvm.org/D43586
Files:
lib/CodeGen/CGDecl.cpp
test/CodeGenCXX/block-inalloca.cpp
Index: test/CodeGenCXX/block-inalloca.cpp
