[PATCH] D43630: [Driver] Fix search paths on x32

2022-08-09 Thread Jessica Clarke via Phabricator via cfe-commits
jrtc27 abandoned this revision. jrtc27 added a comment. Herald added a subscriber: pengfei. Herald added a project: All. Superseded by D52050 Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D43630/new/ https://reviews.llvm.org/D4363

[PATCH] D43630: [Driver] Fix search paths on x32

2018-09-13 Thread John Paul Adrian Glaubitz via Phabricator via cfe-commits
glaubitz added a comment. I have pushed a rebase revision here: https://reviews.llvm.org/D52050 I have no idea how to edit the author though. Repository: rC Clang https://reviews.llvm.org/D43630 ___ cfe-commits mailing list cfe-commits@lists.llv

[PATCH] D43630: [Driver] Fix search paths on x32

2018-09-13 Thread John Paul Adrian Glaubitz via Phabricator via cfe-commits
glaubitz added a comment. I don't think that "test/Driver/linux-header-search.cpp" needs to be updated. x32 is actually supported in both an x86_64-linux-gnu environment and x86_64-linux-gnux32 environment. In order to update test/Driver/linux-header-search.cpp, we would have to add a debian-10

[PATCH] D43630: [Driver] Fix search paths on x32

2018-09-13 Thread John Paul Adrian Glaubitz via Phabricator via cfe-commits
glaubitz added a comment. I have just rebased the patch and I am looking at the tests now. Repository: rC Clang https://reviews.llvm.org/D43630 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo

[PATCH] D43630: [Driver] Fix search paths on x32

2018-09-08 Thread Sylvestre Ledru via Phabricator via cfe-commits
sylvestre.ledru added a comment. @jrtc27 are you going to take care of the tests? Thanks Repository: rC Clang https://reviews.llvm.org/D43630 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/c

[PATCH] D43630: [Driver] Fix search paths on x32

2018-08-22 Thread Derek Schuff via Phabricator via cfe-commits
dschuff added a comment. This should probably have some tests. It looks like there are some existing x32 tests in test/Driver/linux-header-search.cpp and test/Driver/cross-linux.c that might be relevant for updating. Repository: rC Clang https://reviews.llvm.org/D43630 __

[PATCH] D43630: [Driver] Fix search paths on x32

2018-08-22 Thread James Clarke via Phabricator via cfe-commits
jrtc27 added a comment. Ping? Repository: rC Clang https://reviews.llvm.org/D43630 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D43630: [Driver] Fix search paths on x32

2018-02-28 Thread John Paul Adrian Glaubitz via Phabricator via cfe-commits
glaubitz added a comment. As a heads-up, powerpcspe needs a similar treatment as it suffers from the same problem: cd build-llvm \ CFLAGS=`dpkg-buildflags --get CFLAGS`; \ CFLAGS="$CFLAGS `dpkg-buildflags --get CPPFLAGS`"; \ echo $CFLAGS; \ bin/clang++ -c $CFLAGS -std=c++11 ../lib/Fuzz

[PATCH] D43630: [Driver] Fix search paths on x32

2018-02-22 Thread James Clarke via Phabricator via cfe-commits
jrtc27 created this revision. Herald added a subscriber: cfe-commits. When targeting x32, the x32 libraries and headers should be used, not the x86_64 ones (which may not even be available), so prioritise those and use the right multiarch triple. Repository: rC Clang https://reviews.llvm.org/