[PATCH] D43779: [Tooling] [0/1] Refactor FrontendActionFactory::create() to return std::unique_ptr<>

lebedev.ri abandoned this revision. lebedev.ri added a comment. Herald added a project: LLVM. Superseded by D66960 Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D43779/new/ https://reviews.llvm.org/D43779

[PATCH] D43779: [Tooling] [0/1] Refactor FrontendActionFactory::create() to return std::unique_ptr<>

dblaikie added subscribers: lebedev.ri, dblaikie. dblaikie added a comment. FWIW - I had some thoughts on this a while back: https://reviews.llvm.org/D4313 Repository: rL LLVM https://reviews.llvm.org/D43779 ___ cfe-commits mailing list

Re: [PATCH] D43779: [Tooling] [0/1] Refactor FrontendActionFactory::create() to return std::unique_ptr<>

FWIW - I had some thoughts on this a while back: https://reviews.llvm.org/D4313 On Mon, Apr 9, 2018 at 4:54 AM Roman Lebedev via Phabricator via llvm-commits wrote: > lebedev.ri added a comment. > > In https://reviews.llvm.org/D43779#1061444, @alexfh wrote: > > > In

[PATCH] D43779: [Tooling] [0/1] Refactor FrontendActionFactory::create() to return std::unique_ptr<>

lebedev.ri added a comment. In https://reviews.llvm.org/D43779#1061444, @alexfh wrote: > In https://reviews.llvm.org/D43779#1061043, @lebedev.ri wrote: > > > Hmm. > > Got back to this issue. > > > > Not reproducible with gcc-4.8.5 and gcc-4.9.3 in ubuntu 16.04 chroot. > > *Reproducible* with

[PATCH] D43779: [Tooling] [0/1] Refactor FrontendActionFactory::create() to return std::unique_ptr<>

alexfh added a comment. In https://reviews.llvm.org/D43779#1061043, @lebedev.ri wrote: > Hmm. > Got back to this issue. > > Not reproducible with gcc-4.8.5 and gcc-4.9.3 in ubuntu 16.04 chroot. > *Reproducible* with gcc-4.8.4 and gcc-4.9.2 in debian oldstable (Jessie) > chroot. > So one

[PATCH] D43779: [Tooling] [0/1] Refactor FrontendActionFactory::create() to return std::unique_ptr<>

lebedev.ri added a comment. Hmm. Got back to this issue. Not reproducible with gcc-4.8.5 and gcc-4.9.3 in ubuntu 16.04 chroot. *Reproducible* with gcc-4.8.4 and gcc-4.9.2 in debian oldstable (Jessie) chroot. So one might assume that it was fixed. I did try to creduce the crasher, but not not

[PATCH] D43779: [Tooling] [0/1] Refactor FrontendActionFactory::create() to return std::unique_ptr<>

lebedev.ri added a comment. In https://reviews.llvm.org/D43779#1021959, @alexfh wrote: > Do you have a way to reproduce the gcc crashes? Not presently. I'm on debian sid, so gcc4.8 is a lost-for-good relic from ancient past. I'll try to create an debian-oldstable chroot, which still has

[PATCH] D43779: [Tooling] [0/1] Refactor FrontendActionFactory::create() to return std::unique_ptr<>

alexfh added a comment. Do you have a way to reproduce the gcc crashes? Repository: rL LLVM https://reviews.llvm.org/D43779 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D43779: [Tooling] [0/1] Refactor FrontendActionFactory::create() to return std::unique_ptr<>

lebedev.ri reopened this revision. lebedev.ri added a comment. This revision is now accepted and ready to land. And reverted. This broke gcc4.8 builds, compiler just segfaults: http://lab.llvm.org:8011/builders/clang-atom-d525-fedora-rel/builds/14909 ... [72/368] Building CXX object

[PATCH] D43779: [Tooling] [0/1] Refactor FrontendActionFactory::create() to return std::unique_ptr<>

This revision was automatically updated to reflect the committed changes. Closed by commit rL326201: [Tooling] [0/1] Refactor FrontendActionFactory::create() to return std… (authored by lebedevri, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D43779: [Tooling] [0/1] Refactor FrontendActionFactory::create() to return std::unique_ptr<>

This revision was automatically updated to reflect the committed changes. Closed by commit rC326201: [Tooling] [0/1] Refactor FrontendActionFactory::create() to return std… (authored by lebedevri, committed by ). Repository: rC Clang https://reviews.llvm.org/D43779 Files:

[PATCH] D43779: [Tooling] [0/1] Refactor FrontendActionFactory::create() to return std::unique_ptr<>

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. Awesome, thank you for this cleanup! Repository: rC Clang https://reviews.llvm.org/D43779 ___ cfe-commits mailing list

[PATCH] D43779: [Tooling] [0/1] Refactor FrontendActionFactory::create() to return std::unique_ptr<>

lebedev.ri created this revision. lebedev.ri added reviewers: klimek, bkramer, alexfh, pcc. lebedev.ri added a project: clang. Noticed during review of https://reviews.llvm.org/D41102. I'm not sure whether there are any principal reasons why it returns raw owning pointer, or it is just a old