[PATCH] D43783: [OpenCL] Remove block invoke function from emitted block literal struct

2018-10-30 Thread Anastasia Stulova via Phabricator via cfe-commits
Anastasia added a comment. In https://reviews.llvm.org/D43783#1272001, @AlexeySotkin wrote: > In https://reviews.llvm.org/D43783#1215573, @Anastasia wrote: > > > In https://reviews.llvm.org/D43783#1212485, @yaxunl wrote: > > > > > In https://reviews.llvm.org/D43783#1204353, @svenvh wrote: > > >

[PATCH] D43783: [OpenCL] Remove block invoke function from emitted block literal struct

2018-10-23 Thread Alexey Sotkin via Phabricator via cfe-commits
AlexeySotkin added a comment. In https://reviews.llvm.org/D43783#1215573, @Anastasia wrote: > In https://reviews.llvm.org/D43783#1212485, @yaxunl wrote: > > > In https://reviews.llvm.org/D43783#1204353, @svenvh wrote: > > > > > Sorry for digging up an old commit... > > > > > > Apparently this

[PATCH] D43783: [OpenCL] Remove block invoke function from emitted block literal struct

2018-10-02 Thread Sven van Haastregt via Phabricator via cfe-commits
svenvh added a comment. Reverted in r343582, test added in r343583. Repository: rC Clang https://reviews.llvm.org/D43783 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D43783: [OpenCL] Remove block invoke function from emitted block literal struct

2018-09-24 Thread Anastasia Stulova via Phabricator via cfe-commits
Anastasia added a comment. In https://reviews.llvm.org/D43783#1235126, @yaxunl wrote: > In https://reviews.llvm.org/D43783#1235090, @Anastasia wrote: > > > Ping! Do you still plan to do this? :) > > > Sorry I caught up in something else. Since there are some subsequent commits, > it may take

[PATCH] D43783: [OpenCL] Remove block invoke function from emitted block literal struct

2018-09-14 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl added a comment. In https://reviews.llvm.org/D43783#1235090, @Anastasia wrote: > Ping! Do you still plan to do this? :) Sorry I caught up in something else. Since there are some subsequent commits, it may take some efforts to revert it. Repository: rC Clang

[PATCH] D43783: [OpenCL] Remove block invoke function from emitted block literal struct

2018-09-14 Thread Anastasia Stulova via Phabricator via cfe-commits
Anastasia added a comment. Ping! Do you still plan to do this? :) Repository: rC Clang https://reviews.llvm.org/D43783 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D43783: [OpenCL] Remove block invoke function from emitted block literal struct

2018-08-29 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl added a comment. In https://reviews.llvm.org/D43783#1215573, @Anastasia wrote: > In https://reviews.llvm.org/D43783#1212485, @yaxunl wrote: > > > In https://reviews.llvm.org/D43783#1204353, @svenvh wrote: > > > > > Sorry for digging up an old commit... > > > > > > Apparently this broke

[PATCH] D43783: [OpenCL] Remove block invoke function from emitted block literal struct

2018-08-28 Thread Anastasia Stulova via Phabricator via cfe-commits
Anastasia added a comment. In https://reviews.llvm.org/D43783#1212485, @yaxunl wrote: > In https://reviews.llvm.org/D43783#1204353, @svenvh wrote: > > > Sorry for digging up an old commit... > > > > Apparently this broke block arguments, e.g. the following test case: > > > > int foo(int (^

[PATCH] D43783: [OpenCL] Remove block invoke function from emitted block literal struct

2018-08-24 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl added a comment. Herald added a subscriber: jvesely. In https://reviews.llvm.org/D43783#1204353, @svenvh wrote: > Sorry for digging up an old commit... > > Apparently this broke block arguments, e.g. the following test case: > > int foo(int (^ bl)(void)) { > return bl(); > } > >

[PATCH] D43783: [OpenCL] Remove block invoke function from emitted block literal struct

2018-08-17 Thread Sven van Haastregt via Phabricator via cfe-commits
svenvh added a comment. Sorry for digging up an old commit... Apparently this broke block arguments, e.g. the following test case: int foo(int (^ bl)(void)) { return bl(); } int get21() { return foo(^{return 21;}); } int get42() { return foo(^{return 42;}); } In

[PATCH] D43783: [OpenCL] Remove block invoke function from emitted block literal struct

2018-03-07 Thread Yaxun Liu via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC326937: [OpenCL] Remove block invoke function from emitted block literal struct (authored by yaxunl, committed by ). Repository: rC Clang https://reviews.llvm.org/D43783 Files:

[PATCH] D43783: [OpenCL] Remove block invoke function from emitted block literal struct

2018-03-06 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl added inline comments. Comment at: lib/CodeGen/CGBlocks.cpp:1065-1067 + llvm::Value *FuncPtr; + if (!CGM.getLangOpts().OpenCL) { bader wrote: > I think it would be more readable if we merge this if statement with the if > statement at the line #1103.

[PATCH] D43783: [OpenCL] Remove block invoke function from emitted block literal struct

2018-03-06 Thread Alexey Bader via Phabricator via cfe-commits
bader accepted this revision. bader added a comment. This revision is now accepted and ready to land. Hi Sam, Sorry for the delay. LGTM, I have only minor refactoring suggestion. Thanks, Alexey Comment at: lib/CodeGen/CGBlocks.cpp:1065-1067 + llvm::Value *FuncPtr; + if

[PATCH] D43783: [OpenCL] Remove block invoke function from emitted block literal struct

2018-03-05 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl added a comment. ping https://reviews.llvm.org/D43783 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D43783: [OpenCL] Remove block invoke function from emitted block literal struct

2018-02-26 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl created this revision. yaxunl added reviewers: b-sumner, Anastasia, bader. Herald added a subscriber: nhaehnle. OpenCL runtime tracks the invoke function emitted for any block expression. Due to restrictions on blocks in OpenCL (v2.0 s6.12.5), it is always possible to know the block invoke