This revision was automatically updated to reflect the committed changes.
Closed by commit rL326645: Better OpenBSD frontend support (authored by kamil,
committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D43818?vs=136804&id=136903#toc
Rep
devnexen updated this revision to Diff 136804.
devnexen added a comment.
backtrace on OpenBSD is not base library but a package. Plus not needed for the
UBsan subset.
https://reviews.llvm.org/D43818
Files:
lib/Driver/ToolChain.cpp
lib/Driver/ToolChains/CommonArgs.cpp
lib/Driver/ToolChain
devnexen added inline comments.
Comment at: lib/Driver/ToolChains/CommonArgs.cpp:545
CmdArgs.push_back("-lpthread");
-CmdArgs.push_back("-lrt");
+if (TC.getTriple().getOS() != llvm::Triple::OpenBSD)
+ CmdArgs.push_back("-lrt");
krytarowski wrote
krytarowski added inline comments.
Comment at: lib/Driver/ToolChains/CommonArgs.cpp:545
CmdArgs.push_back("-lpthread");
-CmdArgs.push_back("-lrt");
+if (TC.getTriple().getOS() != llvm::Triple::OpenBSD)
+ CmdArgs.push_back("-lrt");
It's a matter
devnexen added a comment.
Alright then. I ll probably try to push the compiler-rt counterpart (for only
ubsan) within the week, it can detects integer overflow already rightfully.
Repository:
rC Clang
https://reviews.llvm.org/D43818
___
cfe-comm
krytarowski added a comment.
TSan actually demands a lot of meta-data, similar to MSan.
Repository:
rC Clang
https://reviews.llvm.org/D43818
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cf
devnexen added a comment.
Also true ... on OpenBSD the number of sanitisers support list won t be
enormous ... ubsan maybe tsan ... the xray instrumentation perharps ...
Repository:
rC Clang
https://reviews.llvm.org/D43818
___
cfe-commits mailin
krytarowski added a comment.
OpenBSD might also have issues with allocating lazily large memory regions for
metadata, so on amd64 with 40/48-bit address space shadow is extremely large.
Although it's best to investigate it. Just noting another potential showstopper.
Repository:
rC Clang
htt
devnexen added a comment.
In https://reviews.llvm.org/D43818#1020577, @krytarowski wrote:
> OpenBSD ships with an aggressive ASLR (or ASR) implementation with
> fragmentation of user address space. As far as I can tell, it's not possible
> to disable it. This means that you are restricted to UB
krytarowski added a reviewer: vitalybuka.
krytarowski added a comment.
OpenBSD ships with an aggressive ASLR (or ASR) implementation with
fragmentation of user address space. As far as I can tell, it's not possible to
disable it. This means that you are restricted to UBSan.
Repository:
rC Cl
devnexen created this revision.
devnexen created this object with visibility "All Users".
Herald added subscribers: cfe-commits, krytarowski.
devnexen added reviewers: dlj, krytarowski.
- Like other *BSD, conditioning certain flags to pass
- To prepare future OpenBSD sanitisers.
Repository:
rC
11 matches
Mail list logo