[PATCH] D44003: [clangd] Fix unintentionally loose fuzzy matching, and the tests masking it.

2018-03-05 Thread Sam McCall via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rCTE326721: [clangd] Fix unintentionally loose fuzzy matching, and the tests masking it. (authored by sammccall, committed by ). Changed prior to commit:

[PATCH] D44003: [clangd] Fix unintentionally loose fuzzy matching, and the tests masking it.

2018-03-05 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM, but note the unreachable code comment Comment at: unittests/clangd/FuzzyMatchTests.cpp:35 + + friend raw_ostream <<(raw_ostream , const ExpectedMatch )

[PATCH] D44003: [clangd] Fix unintentionally loose fuzzy matching, and the tests masking it.

2018-03-02 Thread Sam McCall via Phabricator via cfe-commits
sammccall updated this revision to Diff 136719. sammccall added a comment. test tweaks Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44003 Files: clangd/FuzzyMatch.cpp clangd/FuzzyMatch.h unittests/clangd/FuzzyMatchTests.cpp unittests/clangd/IndexTests.cpp Index:

[PATCH] D44003: [clangd] Fix unintentionally loose fuzzy matching, and the tests masking it.

2018-03-02 Thread Sam McCall via Phabricator via cfe-commits
sammccall created this revision. Herald added subscribers: cfe-commits, ioeric, jkorous-apple, ilya-biryukov, klimek. sammccall updated this revision to Diff 136719. sammccall added a comment. test tweaks The intent was that [ar] doesn't match "FooBar"; the first character must match a Head