[PATCH] D44173: [clang-tidy] Add "portability" module and rename readability-simd-intrinsics to portability-simd-intrinsics

This revision was automatically updated to reflect the committed changes. Closed by commit rL326909: [clang-tidy] Add "portability" module and rename readability-simd-intrinsics to… (authored by MaskRay, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://r

[PATCH] D44173: [clang-tidy] Add "portability" module and rename readability-simd-intrinsics to portability-simd-intrinsics

MaskRay updated this revision to Diff 137406. MaskRay added a comment. ReleaseNotes.rst Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44173 Files: clang-tidy/CMakeLists.txt clang-tidy/plugin/CMakeLists.txt clang-tidy/plugin/ClangTidyPlugin.cpp clang-tidy/portability/CM

[PATCH] D44173: [clang-tidy] Add "portability" module and rename readability-simd-intrinsics to portability-simd-intrinsics

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. Thank you! LGTM Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44173 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D44173: [clang-tidy] Add "portability" module and rename readability-simd-intrinsics to portability-simd-intrinsics

Eugene.Zelenko added inline comments. Comment at: docs/ReleaseNotes.rst:60 +- New module `portability` and new `portability-simd-intrinsics + `_ check Module and check from it sh

[PATCH] D44173: [clang-tidy] Add "portability" module and rename readability-simd-intrinsics to portability-simd-intrinsics

MaskRay updated this revision to Diff 137293. MaskRay marked 2 inline comments as done. MaskRay added a comment. Mention new module `portability` in docs/ReleaseNotes.rst Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44173 Files: clang-tidy/CMakeLists.txt clang-tidy/plugin

[PATCH] D44173: [clang-tidy] Add "portability" module and rename readability-simd-intrinsics to portability-simd-intrinsics

Eugene.Zelenko added a comment. Please mention new module in Release Notes. I think new modules should be before new checks there. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44173 ___ cfe-commits mailing list cfe-commits@lists.

[PATCH] D44173: [clang-tidy] Add "portability" module and rename readability-simd-intrinsics to portability-simd-intrinsics

MaskRay marked 2 inline comments as done. MaskRay added inline comments. Comment at: clang-tidy/portability/SIMDIntrinsicsCheck.cpp:141 if (!New.empty()) { std::string Message; // If Suggest is true, give a P0214 alternative, otherwise point it out it ---

[PATCH] D44173: [clang-tidy] Add "portability" module and rename readability-simd-intrinsics to portability-simd-intrinsics

MaskRay updated this revision to Diff 137275. MaskRay added a comment. std::string -> llvm::SmallString Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44173 Files: clang-tidy/CMakeLists.txt clang-tidy/plugin/CMakeLists.txt clang-tidy/plugin/ClangTidyPlugin.cpp clang-tid

[PATCH] D44173: [clang-tidy] Add "portability" module and rename readability-simd-intrinsics to portability-simd-intrinsics

lebedev.ri added a comment. I should have seen in during the initial review, but better now than never, right? :) Comment at: clang-tidy/portability/SIMDIntrinsicsCheck.cpp:141 if (!New.empty()) { std::string Message; // If Suggest is true, give a P0214 alternativ