[PATCH] D44381: [mips] Prevent PIC to be set to level 2

This revision was automatically updated to reflect the committed changes. Closed by commit rL330118: [mips] Prevent PIC to be set to level 2 (authored by abeserminji, committed by ). Changed prior to commit: https://reviews.llvm.org/D44381?vs=142406&id=142609#toc Repository: rL LLVM https:/

[PATCH] D44381: [mips] Prevent PIC to be set to level 2

This revision was automatically updated to reflect the committed changes. Closed by commit rC330118: [mips] Prevent PIC to be set to level 2 (authored by abeserminji, committed by ). Repository: rL LLVM https://reviews.llvm.org/D44381 Files: lib/Driver/ToolChains/CommonArgs.cpp test/Drive

[PATCH] D44381: [mips] Prevent PIC to be set to level 2

sdardis accepted this revision. sdardis added a comment. This revision is now accepted and ready to land. LGTM. Repository: rC Clang https://reviews.llvm.org/D44381 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi

[PATCH] D44381: [mips] Prevent PIC to be set to level 2

abeserminji updated this revision to Diff 142406. abeserminji marked an inline comment as done. abeserminji edited the summary of this revision. abeserminji added a comment. Comments resolved. Repository: rC Clang https://reviews.llvm.org/D44381 Files: lib/Driver/ToolChains/CommonArgs.cpp

[PATCH] D44381: [mips] Prevent PIC to be set to level 2

sdardis requested changes to this revision. sdardis added a comment. This revision now requires changes to proceed. You should also update the description of the patch. Repository: rC Clang https://reviews.llvm.org/D44381 ___ cfe-commits mailing

[PATCH] D44381: [mips] Prevent PIC to be set to level 2

sdardis added inline comments. Comment at: lib/Driver/ToolChains/CommonArgs.cpp:983 + return std::make_tuple(llvm::Reloc::Static, 0U, false); +// It's never PIC level 2 for mips. +IsPICLevelTwo = false; Can you reformulate this comment to say that MI