[PATCH] D44435: Add the module name to __cuda_module_ctor and __cuda_module_dtor for unique function names

SimeonEhrig added inline comments. Comment at: unittests/CodeGen/IncrementalProcessingTest.cpp:176-178 + +// In CUDA incremental processing, a CUDA ctor or dtor will be generated for +// every statement if a fatbinary file exists. tra wrote: > SimeonEhrig

[PATCH] D44435: Add the module name to __cuda_module_ctor and __cuda_module_dtor for unique function names

tra added inline comments. Comment at: unittests/CodeGen/IncrementalProcessingTest.cpp:176-178 + +// In CUDA incremental processing, a CUDA ctor or dtor will be generated for +// every statement if a fatbinary file exists. SimeonEhrig wrote: > tra wrote: > >

[PATCH] D44435: Add the module name to __cuda_module_ctor and __cuda_module_dtor for unique function names

SimeonEhrig added inline comments. Comment at: unittests/CodeGen/IncrementalProcessingTest.cpp:176-178 + +// In CUDA incremental processing, a CUDA ctor or dtor will be generated for +// every statement if a fatbinary file exists. tra wrote: > SimeonEhrig

[PATCH] D44435: Add the module name to __cuda_module_ctor and __cuda_module_dtor for unique function names

tra added inline comments. Comment at: unittests/CodeGen/IncrementalProcessingTest.cpp:176-178 + +// In CUDA incremental processing, a CUDA ctor or dtor will be generated for +// every statement if a fatbinary file exists. SimeonEhrig wrote: > tra wrote: > >

[PATCH] D44435: Add the module name to __cuda_module_ctor and __cuda_module_dtor for unique function names

SimeonEhrig added inline comments. Comment at: unittests/CodeGen/IncrementalProcessingTest.cpp:176-178 + +// In CUDA incremental processing, a CUDA ctor or dtor will be generated for +// every statement if a fatbinary file exists. tra wrote: > SimeonEhrig

[PATCH] D44435: Add the module name to __cuda_module_ctor and __cuda_module_dtor for unique function names

rjmccall added inline comments. Comment at: lib/CodeGen/CGCUDANV.cpp:281 + // get name from the module to generate unique ctor name for every module + SmallString<128> ModuleName rsmith wrote: > rjmccall wrote: > > v.g.vassilev wrote: > > > rjmccall wrote: >

[PATCH] D44435: Add the module name to __cuda_module_ctor and __cuda_module_dtor for unique function names

rsmith added inline comments. Comment at: lib/CodeGen/CGCUDANV.cpp:281 + // get name from the module to generate unique ctor name for every module + SmallString<128> ModuleName rjmccall wrote: > v.g.vassilev wrote: > > rjmccall wrote: > > > SimeonEhrig

[PATCH] D44435: Add the module name to __cuda_module_ctor and __cuda_module_dtor for unique function names

rjmccall added inline comments. Comment at: lib/CodeGen/CGCUDANV.cpp:281 + // get name from the module to generate unique ctor name for every module + SmallString<128> ModuleName v.g.vassilev wrote: > rjmccall wrote: > > SimeonEhrig wrote: > > > tra wrote: >

[PATCH] D44435: Add the module name to __cuda_module_ctor and __cuda_module_dtor for unique function names

v.g.vassilev added inline comments. Comment at: lib/CodeGen/CGCUDANV.cpp:281 + // get name from the module to generate unique ctor name for every module + SmallString<128> ModuleName rjmccall wrote: > SimeonEhrig wrote: > > tra wrote: > > > SimeonEhrig

[PATCH] D44435: Add the module name to __cuda_module_ctor and __cuda_module_dtor for unique function names

tra added inline comments. Comment at: unittests/CodeGen/IncrementalProcessingTest.cpp:176-178 + +// In CUDA incremental processing, a CUDA ctor or dtor will be generated for +// every statement if a fatbinary file exists. SimeonEhrig wrote: > tra wrote: > > I

[PATCH] D44435: Add the module name to __cuda_module_ctor and __cuda_module_dtor for unique function names

rjmccall added inline comments. Comment at: lib/CodeGen/CGCUDANV.cpp:281 + // get name from the module to generate unique ctor name for every module + SmallString<128> ModuleName SimeonEhrig wrote: > tra wrote: > > SimeonEhrig wrote: > > > rjmccall wrote: >

[PATCH] D44435: Add the module name to __cuda_module_ctor and __cuda_module_dtor for unique function names

SimeonEhrig marked an inline comment as done. SimeonEhrig added inline comments. Comment at: lib/CodeGen/CGCUDANV.cpp:281 + // get name from the module to generate unique ctor name for every module + SmallString<128> ModuleName rjmccall wrote: > Please

[PATCH] D44435: Add the module name to __cuda_module_ctor and __cuda_module_dtor for unique function names

tra added inline comments. Comment at: lib/CodeGen/CGCUDANV.cpp:281 + // get name from the module to generate unique ctor name for every module + SmallString<128> ModuleName rjmccall wrote: > Please explain in the comment *why* you're doing this. It's just

[PATCH] D44435: Add the module name to __cuda_module_ctor and __cuda_module_dtor for unique function names

SimeonEhrig updated this revision to Diff 138224. SimeonEhrig added a comment. change comment of the example function for TEST(IncrementalProcessing, EmitCUDAGlobalInitFunc) Repository: rC Clang https://reviews.llvm.org/D44435 Files: lib/CodeGen/CGCUDANV.cpp

[PATCH] D44435: Add the module name to __cuda_module_ctor and __cuda_module_dtor for unique function names

rjmccall added inline comments. Comment at: lib/CodeGen/CGCUDANV.cpp:281 + // get name from the module to generate unique ctor name for every module + SmallString<128> ModuleName Please explain in the comment *why* you're doing this. It's just for

[PATCH] D44435: Add the module name to __cuda_module_ctor and __cuda_module_dtor for unique function names

SimeonEhrig created this revision. SimeonEhrig added reviewers: karies, v.g.vassilev, rsmith, rjmccall. This allows multi-module / incremental compilation environments to have unique global CUDA constructor and destructor function names. Repository: rC Clang https://reviews.llvm.org/D44435