benhamilton added a comment.
> One way in which DenseSet is better is that it supports StringRefs - we don't
> have to define hash. Seems like the lack of this override in core LLVM
> suggests that unordered_set is not commonly used with StringRefs.
Makes sense, thanks.
Repository:
rC
benhamilton added a comment.
I'm fine with whichever approach we use, but I'll defer to @krasimir here.
(I'm not fully sure why `llvm::DenseSet` is better than `std::unsorted_set`,
but I'm sure you and @krasimir understand the subtleties better than I do.)
Repository:
rC Clang
bkramer accepted this revision.
bkramer added a comment.
This revision is now accepted and ready to land.
I wouldn't say that this is more maintainable, but I'm not the maintainer of
clang-format.
Repository:
rC Clang
https://reviews.llvm.org/D44695
krasimir created this revision.
Herald added subscribers: cfe-commits, klimek.
The array + binary_search requires the initializer list of identifiers to be
sorted. I can imagine how this list might change frequently while the support
for ObjectiveC improves (https://reviews.llvm.org/D44632). The
