[PATCH] D44743: [clang-tidy] Marking hicpp-no-assembler-msvc unsupported on Windows

2018-03-21 Thread Julie Hockett via Phabricator via cfe-commits
juliehockett closed this revision.
juliehockett added a comment.

Committed in r328127.


https://reviews.llvm.org/D44743



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits


[PATCH] D44743: [clang-tidy] Marking hicpp-no-assembler-msvc unsupported on Windows

2018-03-21 Thread Petr Hosek via Phabricator via cfe-commits
phosek accepted this revision.
phosek added a comment.
This revision is now accepted and ready to land.

LGTM


https://reviews.llvm.org/D44743



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits


[PATCH] D44743: [clang-tidy] Marking hicpp-no-assembler-msvc unsupported on Windows

2018-03-21 Thread Julie Hockett via Phabricator via cfe-commits
juliehockett created this revision.
juliehockett added reviewers: zturner, phosek.
juliehockett added a project: clang-tools-extra.
Herald added a subscriber: xazax.hun.

After changes to lit.site.cfg.in, the test is now running (and failing) on 
windows, so temporarily marking it unsupported. See PR36855 for more details.


https://reviews.llvm.org/D44743

Files:
  test/clang-tidy/hicpp-no-assembler-msvc.cpp


Index: test/clang-tidy/hicpp-no-assembler-msvc.cpp
===
--- test/clang-tidy/hicpp-no-assembler-msvc.cpp
+++ test/clang-tidy/hicpp-no-assembler-msvc.cpp
@@ -1,4 +1,6 @@
 // REQUIRES: system-windows
+// FIXME: Re-enable test on windows (PR36855)
+// UNSUPPORTED: system-windows
 // RUN: %check_clang_tidy %s hicpp-no-assembler %t
 
 void f() {


Index: test/clang-tidy/hicpp-no-assembler-msvc.cpp
===
--- test/clang-tidy/hicpp-no-assembler-msvc.cpp
+++ test/clang-tidy/hicpp-no-assembler-msvc.cpp
@@ -1,4 +1,6 @@
 // REQUIRES: system-windows
+// FIXME: Re-enable test on windows (PR36855)
+// UNSUPPORTED: system-windows
 // RUN: %check_clang_tidy %s hicpp-no-assembler %t
 
 void f() {
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits