[PATCH] D44764: [clangd] Use operator<< to prevent printers issues in Gtest

This revision was automatically updated to reflect the committed changes. Closed by commit rL329725: [clangd] Use operator<< to prevent printers issues in Gtest (authored by malaperle, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D44764

[PATCH] D44764: [clangd] Use operator<< to prevent printers issues in Gtest

malaperle added a comment. Thanks! Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44764 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D44764: [clangd] Use operator<< to prevent printers issues in Gtest

sammccall accepted this revision. sammccall added a comment. Sorry I lost track of this. LGTM! Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44764 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bi

[PATCH] D44764: [clangd] Use operator<< to prevent printers issues in Gtest

malaperle added a comment. @sammccall Are you OK with the latest version? Thanks! Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44764 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/lis

[PATCH] D44764: [clangd] Use operator<< to prevent printers issues in Gtest

malaperle added inline comments. Comment at: clangd/Protocol.h:673 json::Expr toJSON(const CompletionItem &); +std::ostream &operator<<(std::ostream &, const CompletionItem &); sammccall wrote: > I think raw_ostream should work fine here, it's what we've done

[PATCH] D44764: [clangd] Use operator<< to prevent printers issues in Gtest

malaperle updated this revision to Diff 140382. malaperle marked an inline comment as done. malaperle added a comment. Use raw_ostream instead. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44764 Files: clangd/Protocol.cpp clangd/Protocol.h unittests/clangd/CodeCompleteT

[PATCH] D44764: [clangd] Use operator<< to prevent printers issues in Gtest

sammccall added a comment. (Thanks for sorting this out BTW!) Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44764 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D44764: [clangd] Use operator<< to prevent printers issues in Gtest

sammccall added inline comments. Comment at: clangd/Protocol.h:673 json::Expr toJSON(const CompletionItem &); +std::ostream &operator<<(std::ostream &, const CompletionItem &); I think raw_ostream should work fine here, it's what we've done elsewhere. Is there

[PATCH] D44764: [clangd] Use operator<< to prevent printers issues in Gtest

malaperle added inline comments. Comment at: unittests/clangd/JSONExprTests.cpp:19 -void PrintTo(const Expr &E, std::ostream *OS) { - llvm::raw_os_ostream(*OS) << llvm::formatv("{0:2}", E); -} This one I couldn't change to operator<< because there was already on