This revision was automatically updated to reflect the committed changes.
Closed by commit rL335546: Add an option to support debug fission on implicit
ThinLTO. (authored by yunlian, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
pcc accepted this revision.
pcc added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D44788
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
yunlian updated this revision to Diff 152794.
https://reviews.llvm.org/D44788
Files:
lib/Driver/ToolChains/CommonArgs.cpp
test/Driver/lto-dwo.c
Index: test/Driver/lto-dwo.c
===
--- /dev/null
+++ test/Driver/lto-dwo.c
@@ -0,0
yunlian marked 2 inline comments as done.
yunlian added a comment.
ping?
https://reviews.llvm.org/D44788
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
yunlian updated this revision to Diff 152120.
yunlian added a comment.
Removed redundant 'if' statement
https://reviews.llvm.org/D44788
Files:
include/clang/Driver/Options.td
lib/Driver/ToolChains/CommonArgs.cpp
test/Driver/lto-dwo.c
Index: test/Driver/lto-dwo.c
yunlian added inline comments.
Comment at: lib/Driver/ToolChains/CommonArgs.cpp:428
+
+ if (Args.hasArg(options::OPT_gsplit_dwarf)) {
+if (!Args.getLastArg(options::OPT_gsplit_dwarf_EQ)) {
pcc wrote:
> If you make this `else if
pcc added inline comments.
Comment at: lib/Driver/ToolChains/CommonArgs.cpp:423
+llvm::sys::path::native(Dwo_Dir, DwoDir);
+llvm::sys::path::append(DwoDir, Twine(Output.getFilename()) + "_dwo");
+CmdArgs.push_back(
I think that if I pass
yunlian added a comment.
ping?
https://reviews.llvm.org/D44788
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
yunlian added a comment.
ping?
https://reviews.llvm.org/D44788
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
yunlian updated this revision to Diff 150419.
yunlian added a comment.
Makes the default value to /path/to/binary_dwo, when DWO_DIR is provided, make
the path to DWO_DIR/path/to/binary_dwo
https://reviews.llvm.org/D44788
Files:
include/clang/Driver/Options.td
yunlian updated this revision to Diff 150028.
https://reviews.llvm.org/D44788
Files:
include/clang/Driver/Options.td
lib/Driver/ToolChains/CommonArgs.cpp
test/Driver/lto-dwo.c
Index: test/Driver/lto-dwo.c
===
--- /dev/null
pcc added inline comments.
Comment at: lib/Driver/ToolChains/CommonArgs.cpp:435
+ CmdArgs.push_back(
+ Args.MakeArgString(Twine("-plugin-opt=objcopy=") + Objcopy));
+ CmdArgs.push_back(
You no longer need to pass `objcopy=`, see D47091.
yunlian marked an inline comment as done.
yunlian added a comment.
Herald added a subscriber: steven_wu.
ping?
https://reviews.llvm.org/D44788
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
yunlian updated this revision to Diff 146698.
yunlian edited the summary of this revision.
yunlian added a comment.
Herald added subscribers: JDevlieghere, aprantl.
Use the option -gsplit-dwarf to make it more consistent.
https://reviews.llvm.org/D44788
Files:
include/clang/Driver/Options.td
pcc added inline comments.
Comment at: lib/Driver/ToolChains/CommonArgs.cpp:423
+Args.MakeArgString(Twine("-plugin-opt=objcopy=") + Objcopy));
+StringRef DWO_Dir = A->getValue();
+CmdArgs.push_back(
Can we default this to a path alongside the
yunlian added a comment.
ping?
https://reviews.llvm.org/D44788
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
yunlian added a comment.
ping?
https://reviews.llvm.org/D44788
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
yunlian added a comment.
I prefer to have a dedicated directory to store all the .dwo files. As dblaikie
said, all the .dwo files are temporary files. In addition, in order to
differentiate the .dwo files generated by different link stage with the same
.o, we need to add
some suffixes to the
yunlian updated this revision to Diff 140857.
https://reviews.llvm.org/D44788
Files:
docs/ClangCommandLineReference.rst
include/clang/Driver/Options.td
lib/Driver/ToolChains/CommonArgs.cpp
test/Driver/lto-dwo.c
Index: test/Driver/lto-dwo.c
yunlian updated this revision to Diff 139956.
https://reviews.llvm.org/D44788
Files:
docs/ClangCommandLineReference.rst
include/clang/Driver/Options.td
lib/Driver/ToolChains/CommonArgs.cpp
test/Driver/lto-dwo.c
Index: lib/Driver/ToolChains/CommonArgs.cpp
dblaikie added a comment.
The only data we have is that where .o files go, .dwo files go beside them.
How to generalize this to other situations isn't really obvious to me -
even for a.out (do you put all the .dwo files next to a.out? in the same
directory? if the names collide, where then? etc).
The only data we have is that where .o files go, .dwo files go beside them.
How to generalize this to other situations isn't really obvious to me -
even for a.out (do you put all the .dwo files next to a.out? in the same
directory? if the names collide, where then? etc).
Interestingly GCC for
probinson added a comment.
In https://reviews.llvm.org/D44788#1046093, @dblaikie wrote:
> In implicit ThinLTO, the object files are only temporary.
>
> Sort of similar to using -gsplit-dwarf when compiling straight to an
> executable (without using -c): "clang++ x.cpp y.cpp -o a.out" - where
>
dblaikie added a subscriber: yunlian.
dblaikie added a comment.
In implicit ThinLTO, the object files are only temporary.
Sort of similar to using -gsplit-dwarf when compiling straight to an
executable (without using -c): "clang++ x.cpp y.cpp -o a.out" - where
should the .dwo files go then? If
In implicit ThinLTO, the object files are only temporary.
Sort of similar to using -gsplit-dwarf when compiling straight to an
executable (without using -c): "clang++ x.cpp y.cpp -o a.out" - where
should the .dwo files go then? If they go where the .o files go, then
they'll be in /tmp/ and get
probinson added a comment.
I don't think requiring a new option is a great user interface. In existing
use cases the location of the .dwo file matches the location of the output
file. Why is this one different?
Repository:
rC Clang
https://reviews.llvm.org/D44788
yunlian added a comment.
I have another one https://reviews.llvm.org/D44792 on LLVM side.
Repository:
rC Clang
https://reviews.llvm.org/D44788
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
pcc added a comment.
Does this depend on another patch?
Repository:
rC Clang
https://reviews.llvm.org/D44788
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
yunlian created this revision.
yunlian added reviewers: tejohnson, dblaikie, pcc.
Herald added subscribers: cfe-commits, inglorion, mehdi_amini.
This adds an option -gthinlto-dwo-dir=. LLVM can create .dwo files in the
given directory
during the implicit ThinLTO link stage.
Repository:
rC
29 matches
Mail list logo
