This revision was automatically updated to reflect the committed changes.
Closed by commit rC329916: [clang-format] Always indent wrapped Objective-C
selector names (authored by benhamilton, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D45004?vs=142183=142187#toc
benhamilton added inline comments.
Comment at: unittests/Format/FormatTest.cpp:7666
FormatStyle Style = getLLVMStyle();
+ // ObjC ignores IndentWrappedFunctionNames when wrapping methods.
Style.IndentWrappedFunctionNames = false;
djasper wrote:
> maybe:
benhamilton updated this revision to Diff 142183.
benhamilton marked an inline comment as done.
benhamilton added a comment.
Update comment.
Repository:
rC Clang
https://reviews.llvm.org/D45004
Files:
lib/Format/ContinuationIndenter.cpp
unittests/Format/FormatTest.cpp
djasper accepted this revision.
djasper added inline comments.
This revision is now accepted and ready to land.
Comment at: unittests/Format/FormatTest.cpp:7666
FormatStyle Style = getLLVMStyle();
+ // ObjC ignores IndentWrappedFunctionNames when wrapping methods.
benhamilton added a comment.
> Ok, you know the ObjC community much better than I do. If you think that
> adding the indentation for ObjC irrespective of the option works for most
> people, I am happy to go with it.
OK, I went ahead and implemented unconditional indenting of wrapped ObjC
benhamilton updated this revision to Diff 141872.
benhamilton added a comment.
- Unconditionally indent wrapped ObjC selector names.
- Partially revert r242484, as it was causing double-indenting (the tests still
pass with it reverted, so I suspect it's no longer necessary).
Repository:
rC
