The matching clangd patch is r329571, I got distracted and it took me a few
minutes to land it. Apologies!
On Mon, Apr 9, 2018 at 4:35 PM Hans Wennborg via Phabricator <
revi...@reviews.llvm.org> wrote:
> hans added a comment.
>
> Some bots are sad:
> http://lab.llvm.org:8011/builders/clang-atom-
hans added a comment.
Some bots are sad:
http://lab.llvm.org:8011/builders/clang-atom-d525-fedora-rel/builds/16346/
http://lab.llvm.org:8011/builders/clang-ppc64be-linux/builds/17364/
http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/builds/28078/
Repository:
rC Clan
ilya-biryukov added a comment.
LGTM, but let's watch out for @akyrtzi's and @arphaman's comments, just in case
they're not happy with the change. In that case we'll have to revert it.
Repository:
rC Clang
https://reviews.llvm.org/D45014
___
cfe-
sammccall added a comment.
Oops, I got my reviews crossed and thought @ilya-biryukov had already approved
it (we chatted about this today)
Repository:
rC Clang
https://reviews.llvm.org/D45014
___
cfe-commits mailing list
cfe-commits@lists.llvm.o
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rC329570: [Index] Return SourceLocation to consumers, not
FileID/Offset pair. (authored by sammccall, committed by ).
Chang
sammccall added a comment.
Ping...
@akyrtzi @arphaman I'm confident there's no functional change in this patch so
I'm happy to land it with just a review from clangd folks, but would be great
to know if you're happy with the interface change.
Repository:
rC Clang
https://reviews.llvm.org/D
sammccall created this revision.
sammccall added reviewers: akyrtzi, arphaman.
Herald added subscribers: cfe-commits, ioeric, ilya-biryukov.
The FileID/Offset conversion is lossy. The code takes the fileLoc, which loses
e.g. the spelling location in some macro cases.
Instead, pass the original Sou
