This revision was automatically updated to reflect the committed changes.
Closed by commit rL329391: Allow the creation of human-friendly ASTDumper to
arbitrary output stream (authored by alexfh, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG. I'll commit the patch for you.
Repository:
rC Clang
https://reviews.llvm.org/D45096
___
cfe-commits mailing list
whisperity updated this revision to Diff 141309.
whisperity added a comment.
Added comments on what `nullptr` means at call sites.
Repository:
rC Clang
https://reviews.llvm.org/D45096
Files:
docs/HowToSetupToolingForLLVM.rst
include/clang/Frontend/ASTConsumers.h
whisperity marked 2 inline comments as done.
whisperity added a comment.
It is also std-out (`llvm::outs()`) in case of `nullptr` and not std-err.
Repository:
rC Clang
https://reviews.llvm.org/D45096
___
cfe-commits mailing list
alexfh added a comment.
Another couple of nits.
Comment at: docs/HowToSetupToolingForLLVM.rst:136
if (this->ASTDump.operator _Bool())
- return clang::CreateASTDumper(this->ASTDumpFilter);
+ return clang::CreateASTDumper(nullptr, this->ASTDumpFilter);
whisperity added a comment.
@alexfh I have updated the patch. I don't have commit rights, so if you think
this is good to go, could you please commit for me?
Repository:
rC Clang
https://reviews.llvm.org/D45096
___
cfe-commits mailing list
whisperity updated this revision to Diff 141194.
whisperity added a comment.
- Overload removed, now only one `CreateASTDumper` function remains.
- Updated the call sites of this function to use this call.
Repository:
rC Clang
https://reviews.llvm.org/D45096
Files:
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
Looks good to me. One optional comment.
Comment at: include/clang/Frontend/ASTConsumers.h:39-41
std::unique_ptr CreateASTDumper(StringRef FilterString,
whisperity created this revision.
whisperity added reviewers: alexfh, klimek, rsmith.
whisperity added a project: clang.
Herald added subscribers: dkrupp, rnkovacs.
`ASTPrinter` allows setting the ouput to any O-Stream, but that printer creates
source-code-like syntax (and is also marked with a
