[PATCH] D45152: [MinGW] Add option for disabling looking for a mingw gcc in PATH

mstorsjo abandoned this revision. mstorsjo added a comment. https://reviews.llvm.org/D45504 fixed the same issue in a better way. Repository: rC Clang https://reviews.llvm.org/D45152 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D45152: [MinGW] Add option for disabling looking for a mingw gcc in PATH

mstorsjo added a comment. In https://reviews.llvm.org/D45152#1057787, @martell wrote: > @mstorsjo I would much prefer to detect the clang sysroot first and if that > exists just ignore the gcc one. > Most of the time clang and gcc will be in the same bin folder and in the > case where the

[PATCH] D45152: [MinGW] Add option for disabling looking for a mingw gcc in PATH

martell added a comment. @mstorsjo I would much prefer to detect the clang sysroot first and if that exists just ignore the gcc one. Most of the time clang and gcc will be in the same bin folder and in the case where the clang sysroot with mingw prefix folders is not found we can just default

[PATCH] D45152: [MinGW] Add option for disabling looking for a mingw gcc in PATH

mstorsjo added a comment. In https://reviews.llvm.org/D45152#1056134, @rnk wrote: > In https://reviews.llvm.org/D45152#1056122, @mstorsjo wrote: > > > In https://reviews.llvm.org/D45152#1055871, @rnk wrote: > > > > > Seems reasonable, looks good. > > > > > > Any opinion on the wording of the

[PATCH] D45152: [MinGW] Add option for disabling looking for a mingw gcc in PATH

rnk added a comment. In https://reviews.llvm.org/D45152#1056122, @mstorsjo wrote: > In https://reviews.llvm.org/D45152#1055871, @rnk wrote: > > > Seems reasonable, looks good. > > > Any opinion on the wording of the option name? Maybe what we're trying to do is find the sysroot relative to

[PATCH] D45152: [MinGW] Add option for disabling looking for a mingw gcc in PATH

mstorsjo added a comment. In https://reviews.llvm.org/D45152#1055871, @rnk wrote: > Seems reasonable, looks good. Any opinion on the wording of the option name? Repository: rC Clang https://reviews.llvm.org/D45152 ___ cfe-commits mailing list

[PATCH] D45152: [MinGW] Add option for disabling looking for a mingw gcc in PATH

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. Seems reasonable, looks good. Repository: rC Clang https://reviews.llvm.org/D45152 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D45152: [MinGW] Add option for disabling looking for a mingw gcc in PATH

mstorsjo added inline comments. Comment at: include/clang/Driver/Options.td:1735 MetaVarName<"">, Flags<[CC1Option]>; +def ignore_gcc : Joined<["--"], "ignore-gcc">, Flags<[DriverOption]>, + HelpText<"Don't look for gcc for finding a suitable sysroot">;

[PATCH] D45152: [MinGW] Add option for disabling looking for a mingw gcc in PATH

mstorsjo created this revision. mstorsjo added reviewers: martell, compnerd, rnk, mati865, ismail, yaron.keren. This avoids looking for a mingw gcc to use as sysroot, preferring the clang installation itself over a similar gcc found in the path. The option name, `--ignore-gcc`, might not be