[PATCH] D45277: [CUDA] Add amdgpu sub archs

yaxunl added inline comments. Comment at: lib/Basic/Targets.cpp:161 +case CudaArch::GFX902: + return "320"; +case CudaArch::UNKNOWN: tra wrote: > yaxunl wrote: > > tra wrote: > > > yaxunl wrote: > > > > tra wrote: > > > > > yaxunl wrote: > > > > > >

[PATCH] D45277: [CUDA] Add amdgpu sub archs

tra added inline comments. Comment at: lib/Basic/Targets.cpp:161 +case CudaArch::GFX902: + return "320"; +case CudaArch::UNKNOWN: yaxunl wrote: > tra wrote: > > yaxunl wrote: > > > tra wrote: > > > > yaxunl wrote: > > > > > tra wrote: > > > > > > Unl

[PATCH] D45277: [CUDA] Add amdgpu sub archs

yaxunl added inline comments. Comment at: lib/Basic/Targets.cpp:161 +case CudaArch::GFX902: + return "320"; +case CudaArch::UNKNOWN: tra wrote: > yaxunl wrote: > > tra wrote: > > > yaxunl wrote: > > > > tra wrote: > > > > > Unless you're planning to

[PATCH] D45277: [CUDA] Add amdgpu sub archs

tra added inline comments. Comment at: lib/Basic/Targets.cpp:161 +case CudaArch::GFX902: + return "320"; +case CudaArch::UNKNOWN: yaxunl wrote: > tra wrote: > > yaxunl wrote: > > > tra wrote: > > > > Unless you're planning to guarantee 1:1 match to f

[PATCH] D45277: [CUDA] Add amdgpu sub archs

yaxunl added inline comments. Comment at: lib/Basic/Targets.cpp:161 +case CudaArch::GFX902: + return "320"; +case CudaArch::UNKNOWN: tra wrote: > yaxunl wrote: > > tra wrote: > > > Unless you're planning to guarantee 1:1 match to functionality provid

[PATCH] D45277: [CUDA] Add amdgpu sub archs

tra added inline comments. Comment at: lib/Basic/Targets.cpp:161 +case CudaArch::GFX902: + return "320"; +case CudaArch::UNKNOWN: yaxunl wrote: > tra wrote: > > Unless you're planning to guarantee 1:1 match to functionality provided by > > nvidia's

[PATCH] D45277: [CUDA] Add amdgpu sub archs

yaxunl added inline comments. Comment at: lib/Basic/Targets.cpp:161 +case CudaArch::GFX902: + return "320"; +case CudaArch::UNKNOWN: tra wrote: > Unless you're planning to guarantee 1:1 match to functionality provided by > nvidia's sm_32, it would b

[PATCH] D45277: [CUDA] Add amdgpu sub archs

tra added a comment. I didn't get a chance to review the patch before it got committed. Comment at: lib/Basic/Targets.cpp:161 +case CudaArch::GFX902: + return "320"; +case CudaArch::UNKNOWN: Unless you're planning to guarantee 1:1 match to function

[PATCH] D45277: [CUDA] Add amdgpu sub archs

This revision was automatically updated to reflect the committed changes. Closed by commit rC329232: [CUDA] Add amdgpu sub archs (authored by yaxunl, committed by ). Repository: rC Clang https://reviews.llvm.org/D45277 Files: include/clang/Basic/Cuda.h lib/Basic/Cuda.cpp lib/Basic/Targe

[PATCH] D45277: [CUDA] Add amdgpu sub archs

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Thanks for splitting the patch up. LGTM. https://reviews.llvm.org/D45277 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://list

[PATCH] D45277: [CUDA] Add amdgpu sub archs

yaxunl created this revision. yaxunl added reviewers: rjmccall, tra. Herald added subscribers: t-tye, tpr, dstuttard, nhaehnle, wdng, kzhuravl, jholewinski. This patch is separated from https://reviews.llvm.org/D45212. Patch by Greg Rodgers. Revised and lit tests added by Yaxun Liu. https://re