[PATCH] D45387: [CUDA] Revert defining __CUDA_ARCH__ for amdgcn targets

2018-04-09 Thread Yaxun Liu via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL329584: [CUDA] Revert defining __CUDA_ARCH__ for amdgcn targets (authored by yaxunl, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D45387: [CUDA] Revert defining __CUDA_ARCH__ for amdgcn targets

2018-04-06 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl added a comment. In https://reviews.llvm.org/D45387#1060194, @tra wrote: > You may want to mention in the commit log that this is a partial unroll of > r329232 / https://reviews.llvm.org/D45277. Will do. Thanks. https://reviews.llvm.org/D45387

[PATCH] D45387: [CUDA] Revert defining __CUDA_ARCH__ for amdgcn targets

2018-04-06 Thread Artem Belevich via Phabricator via cfe-commits
tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. You may want to mention in the commit log that this is a partial unroll of r329232 / https://reviews.llvm.org/D45277. https://reviews.llvm.org/D45387

[PATCH] D45387: [CUDA] Revert defining __CUDA_ARCH__ for amdgcn targets

2018-04-06 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl created this revision. yaxunl added a reviewer: tra. Herald added subscribers: nhaehnle, jholewinski. amdgcn targets only support HIP, which does not define `__CUDA_ARCH__`. `__HIP_DEVICE_COMPILE__` depends on HIP language mode, therefore it needs to be added in a different patch. refer