zinovy.nis added a comment.
The build was broken by someone else's commit then. From my side there was
a warning only I fixed immediately.
ср, 11 апр. 2018 г. в 16:26, Alexander Kornienko via Phabricator <
revi...@reviews.llvm.org>:
> alexfh added a comment.
>
> In
alexfh added a comment.
In https://reviews.llvm.org/D45405#1063890, @zinovy.nis wrote:
> Roman, I see you've fixed them. Thanks a lot!
> I did not face with these errors on MSVS'201 so had no chance to fix early.
No stress, but as Roman said, please watch the bots after committing a patch:
Roman, I see you've fixed them. Thanks a lot!
I did not face with these errors on MSVS'201 so had no chance to fix early.
ср, 11 апр. 2018 г. в 0:02, Roman Lebedev via Phabricator <
revi...@reviews.llvm.org>:
> lebedev.ri added a comment.
>
> This change had two different problems.
> Please
zinovy.nis added a subscriber: angelgarcia.
zinovy.nis added a comment.
Roman, I see you've fixed them. Thanks a lot!
I did not face with these errors on MSVS'201 so had no chance to fix early.
ср, 11 апр. 2018 г. в 0:02, Roman Lebedev via Phabricator <
revi...@reviews.llvm.org>:
> lebedev.ri
lebedev.ri added a comment.
This change had two different problems.
Please watch the bots?
Repository:
rL LLVM
https://reviews.llvm.org/D45405
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
This revision was automatically updated to reflect the committed changes.
Closed by commit rL329730: [clang-tidy] [modernize-use-auto] Add a threshold
for minimal type name length… (authored by zinovy.nis, committed by ).
Herald added subscribers: llvm-commits, klimek.
Changed prior to commit:
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
Looks good. Thank you!
https://reviews.llvm.org/D45405
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
zinovy.nis updated this revision to Diff 141719.
zinovy.nis marked 9 inline comments as done.
zinovy.nis added a comment.
- Default value is **5**.
- Switched to 'tooling::fixit::getText'.
- Updated rst docs.
https://reviews.llvm.org/D45405
Files:
clang-tidy/modernize/UseAutoCheck.cpp
alexfh added inline comments.
Comment at: clang-tidy/modernize/UseAutoCheck.cpp:290
+: ClangTidyCheck(Name, Context), RemoveStars(Options.get("RemoveStars",
0)),
+ MinTypeNameLength(Options.get("MinTypeNameLength", 0)) {}
zinovy.nis wrote:
> alexfh
zinovy.nis added inline comments.
Comment at: clang-tidy/modernize/UseAutoCheck.cpp:290
+: ClangTidyCheck(Name, Context), RemoveStars(Options.get("RemoveStars",
0)),
+ MinTypeNameLength(Options.get("MinTypeNameLength", 0)) {}
alexfh wrote:
> alexfh
alexfh requested changes to this revision.
alexfh added inline comments.
This revision now requires changes to proceed.
Comment at: clang-tidy/modernize/UseAutoCheck.cpp:290
+: ClangTidyCheck(Name, Context), RemoveStars(Options.get("RemoveStars",
0)),
+
lebedev.ri added inline comments.
Comment at: clang-tidy/modernize/UseAutoCheck.cpp:290
+: ClangTidyCheck(Name, Context), RemoveStars(Options.get("RemoveStars",
0)),
+ MinTypeNameLength(Options.get("MinTypeNameLength", 0)) {}
zinovy.nis wrote:
>
zinovy.nis added inline comments.
Comment at: clang-tidy/modernize/UseAutoCheck.cpp:290
+: ClangTidyCheck(Name, Context), RemoveStars(Options.get("RemoveStars",
0)),
+ MinTypeNameLength(Options.get("MinTypeNameLength", 0)) {}
lebedev.ri wrote:
>
lebedev.ri added inline comments.
Comment at: clang-tidy/modernize/UseAutoCheck.cpp:290
+: ClangTidyCheck(Name, Context), RemoveStars(Options.get("RemoveStars",
0)),
+ MinTypeNameLength(Options.get("MinTypeNameLength", 0)) {}
alexfh wrote:
> Maybe
alexfh added inline comments.
Comment at: clang-tidy/modernize/UseAutoCheck.cpp:290
+: ClangTidyCheck(Name, Context), RemoveStars(Options.get("RemoveStars",
0)),
+ MinTypeNameLength(Options.get("MinTypeNameLength", 0)) {}
Maybe make the default 5? Or
hokein added inline comments.
Comment at: docs/clang-tidy/checks/modernize-use-auto.rst:202
+ neither warn nor fix type names having a length less than the option value.
+ The option affects expressions only, not iterators.
+
nit: document the default value.
malcolm.parsons accepted this revision.
malcolm.parsons added a comment.
This revision is now accepted and ready to land.
LGTM!
https://reviews.llvm.org/D45405
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
zinovy.nis updated this revision to Diff 141561.
zinovy.nis added a comment.
- Updated ReleaseNotes.
https://reviews.llvm.org/D45405
Files:
clang-tidy/modernize/UseAutoCheck.cpp
clang-tidy/modernize/UseAutoCheck.h
docs/ReleaseNotes.rst
docs/clang-tidy/checks/modernize-use-auto.rst
malcolm.parsons added a comment.
Please add to release notes.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D45405
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
zinovy.nis created this revision.
zinovy.nis added reviewers: angelgarcia, malcolm.parsons, alexfh.
zinovy.nis added a project: clang-tools-extra.
Herald added subscribers: cfe-commits, xazax.hun.
The threshold option is 'MinTypeNameLength' with default value '0' which means
'replace any
20 matches
Mail list logo