[PATCH] D45411: [Sema] Fix PR35832 - Ambiguity accessing anonymous struct/union with multiple bases.

2018-04-08 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF updated this revision to Diff 141527. EricWF added a comment. I missed a test failure. Reuploading and recommiting latest diff to keep the history. https://reviews.llvm.org/D45411 Files: lib/Sema/SemaExprMember.cpp lib/Sema/TreeTransform.h test/SemaCXX/PR35832.cpp Index:

[PATCH] D45411: [Sema] Fix PR35832 - Ambiguity accessing anonymous struct/union with multiple bases.

2018-04-07 Thread Eric Fiselier via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC329519: [Sema] Fix PR35832 - Ambiguity accessing anonymous struct/union with multiple… (authored by EricWF, committed by ). Repository: rC Clang https://reviews.llvm.org/D45411 Files:

[PATCH] D45411: [Sema] Fix PR35832 - Ambiguity accessing anonymous struct/union with multiple bases.

2018-04-07 Thread John McCall via Phabricator via cfe-commits
rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Well, that is a really silly bug. Fix LGTM. https://reviews.llvm.org/D45411 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D45411: [Sema] Fix PR35832 - Ambiguity accessing anonymous struct/union with multiple bases.

2018-04-07 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF updated this revision to Diff 141522. EricWF added a comment. - Upload with correct test. https://reviews.llvm.org/D45411 Files: lib/Sema/SemaExprMember.cpp test/SemaCXX/PR35832.cpp Index: test/SemaCXX/PR35832.cpp ===

[PATCH] D45411: [Sema] Fix PR35832 - Ambiguity accessing anonymous struct/union with multiple bases.

2018-04-07 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF created this revision. EricWF added reviewers: rsmith, aaron.ballman, rjmccall. EricWF added a dependency: D45410: [Sema] Remove dead code in BuildAnonymousStructUnionMemberReference. NFCI. Currently clang doesn't do qualified lookup when building indirect field decl references. This