[PATCH] D45485: [CMake] Unbreak BUILD_SHARED_LIBS workflow

2018-04-10 Thread David Zarzycki via Phabricator via cfe-commits
davezarzycki added a comment. Great! I'll revisit this patch in a week and see if it is still needed. Hopefully the author of https://reviews.llvm.org/D43578 will make this patch unnecessary by then. Repository: rC Clang https://reviews.llvm.org/D45485

[PATCH] D45485: [CMake] Unbreak BUILD_SHARED_LIBS workflow

2018-04-10 Thread Nico Weber via Phabricator via cfe-commits
thakis added a comment. Thanks for the pointer! I commented on https://reviews.llvm.org/D43578; I'm hoping there's a fix that doesn't require making so many libs depend on clang's IR library. Repository: rC Clang https://reviews.llvm.org/D45485

[PATCH] D45485: [CMake] Unbreak BUILD_SHARED_LIBS workflow

2018-04-10 Thread David Zarzycki via Phabricator via cfe-commits
davezarzycki added a comment. I haven't proven that r329684 is the source of the regression, but it is the only timer related change in the last 24 hours as far as I can tell. Repository: rC Clang https://reviews.llvm.org/D45485 ___ cfe-commits

[PATCH] D45485: [CMake] Unbreak BUILD_SHARED_LIBS workflow

2018-04-10 Thread Nico Weber via Phabricator via cfe-commits
thakis added a comment. Can you link to the recent timer changes? Repository: rC Clang https://reviews.llvm.org/D45485 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D45485: [CMake] Unbreak BUILD_SHARED_LIBS workflow

2018-04-10 Thread David Zarzycki via Phabricator via cfe-commits
davezarzycki created this revision. davezarzycki added reviewers: mspertus, beanz, gottesmm. Herald added a subscriber: mgorny. Due to recent timer changes, we need to add LLVM's `Core` library to avoid undefined symbol errors at link time (`llvm::TimePassesIsEnabled`) when using LLVM's