[PATCH] D45495: [CUDA] Added --[no-]cuda-include-ptx=sm_XX|all option.

2018-04-10 Thread Artem Belevich via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC329737: [CUDA] Added --[no-]cuda-include-ptx=sm_XX|all option. (authored by tra, committed by ). Changed prior to commit: https://reviews.llvm.org/D45495?vs=141882&id=141887#toc Repository: rC Clang

[PATCH] D45495: [CUDA] Added --[no-]cuda-include-ptx=sm_XX|all option.

2018-04-10 Thread Justin Lebar via Phabricator via cfe-commits
jlebar added a comment. lgtm! https://reviews.llvm.org/D45495 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D45495: [CUDA] Added --[no-]cuda-include-ptx=sm_XX|all option.

2018-04-10 Thread Artem Belevich via Phabricator via cfe-commits
tra added a comment. In https://reviews.llvm.org/D45495#1063370, @jlebar wrote: > Where do we document the default values for these flags? Like, how is a user > supposed to figure out whether the default is to include ptx or not? I've updated docs/ClangCommandLineReference.rst. https://revi

[PATCH] D45495: [CUDA] Added --[no-]cuda-include-ptx=sm_XX|all option.

2018-04-10 Thread Artem Belevich via Phabricator via cfe-commits
tra updated this revision to Diff 141882. tra added a comment. Documented new options in ClangCommandLineReference.rst https://reviews.llvm.org/D45495 Files: clang/docs/ClangCommandLineReference.rst clang/include/clang/Driver/Options.td clang/lib/Driver/ToolChains/Cuda.cpp clang/test/Dr

[PATCH] D45495: [CUDA] Added --[no-]cuda-include-ptx=sm_XX|all option.

2018-04-10 Thread Justin Lebar via Phabricator via cfe-commits
jlebar accepted this revision. jlebar added a comment. This revision is now accepted and ready to land. Where do we document the default values for these flags? Like, how is a user supposed to figure out whether the default is to include ptx or not? https://reviews.llvm.org/D45495 _

[PATCH] D45495: [CUDA] Added --[no-]cuda-include-ptx=sm_XX|all option.

2018-04-10 Thread Artem Belevich via Phabricator via cfe-commits
tra created this revision. tra added a reviewer: jlebar. Herald added a subscriber: sanjoy. Currently we always include PTX into the fatbin along with the GPU code. It about doubles the size of the GPU binary we need to carry in the executable. These options allow control inclusion of PTX into GPU