This revision was automatically updated to reflect the committed changes.
Closed by commit rC330064: [Analyzer] Fix for SValBuilder expressions
rearrangement (authored by baloghadamsoftware, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D45557
Files:
NoQ accepted this revision.
NoQ added a comment.
This revision is now accepted and ready to land.
Yup thanks!
https://reviews.llvm.org/D45557
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
baloghadamsoftware updated this revision to Diff 142365.
baloghadamsoftware added a comment.
Updated according to the comments.
https://reviews.llvm.org/D45557
Files:
lib/StaticAnalyzer/Core/SimpleSValBuilder.cpp
test/Analysis/svalbuilder-rearrange-comparisons.c
Index:
NoQ added inline comments.
Comment at: lib/StaticAnalyzer/Core/SimpleSValBuilder.cpp:443
return Sym->getType() == Ty &&
+APSIntType(Int) == BV.getAPSIntType(Sym->getType()) &&
(!BinaryOperator::isComparisonOp(Op) ||
6. Therefore i conclude that this
baloghadamsoftware created this revision.
baloghadamsoftware added a reviewer: NoQ.
Herald added subscribers: dkrupp, a.sidorin, rnkovacs, szepet, xazax.hun,
whisperity.
Herald added a reviewer: george.karpenkov.
Expression rearrangement in SValBuilder (see https://reviews.llvm.org/rL329780)