[PATCH] D45557: [Analyzer] Fix for SValBuilder expressions rearrangement

2018-04-13 Thread Balogh , Ádám via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC330064: [Analyzer] Fix for SValBuilder expressions rearrangement (authored by baloghadamsoftware, committed by ). Repository: rC Clang https://reviews.llvm.org/D45557 Files:

[PATCH] D45557: [Analyzer] Fix for SValBuilder expressions rearrangement

2018-04-13 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Yup thanks! https://reviews.llvm.org/D45557 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D45557: [Analyzer] Fix for SValBuilder expressions rearrangement

2018-04-13 Thread Balogh , Ádám via Phabricator via cfe-commits
baloghadamsoftware updated this revision to Diff 142365. baloghadamsoftware added a comment. Updated according to the comments. https://reviews.llvm.org/D45557 Files: lib/StaticAnalyzer/Core/SimpleSValBuilder.cpp test/Analysis/svalbuilder-rearrange-comparisons.c Index:

[PATCH] D45557: [Analyzer] Fix for SValBuilder expressions rearrangement

2018-04-12 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added inline comments. Comment at: lib/StaticAnalyzer/Core/SimpleSValBuilder.cpp:443 return Sym->getType() == Ty && +APSIntType(Int) == BV.getAPSIntType(Sym->getType()) && (!BinaryOperator::isComparisonOp(Op) || 6. Therefore i conclude that this

[PATCH] D45557: [Analyzer] Fix for SValBuilder expressions rearrangement

2018-04-12 Thread Balogh , Ádám via Phabricator via cfe-commits
baloghadamsoftware created this revision. baloghadamsoftware added a reviewer: NoQ. Herald added subscribers: dkrupp, a.sidorin, rnkovacs, szepet, xazax.hun, whisperity. Herald added a reviewer: george.karpenkov. Expression rearrangement in SValBuilder (see https://reviews.llvm.org/rL329780)