[PATCH] D45873: [OpenCL] Reject virtual functions for OpenCL C++

This revision was automatically updated to reflect the committed changes. Closed by commit rC330579: [OpenCL] Reject virtual functions for OpenCL C++ (authored by svenvh, committed by ). Changed prior to commit: https://reviews.llvm.org/D45873?vs=143330=143524#toc Repository: rC Clang

[PATCH] D45873: [OpenCL] Reject virtual functions for OpenCL C++

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks! https://reviews.llvm.org/D45873 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D45873: [OpenCL] Reject virtual functions for OpenCL C++

svenvh updated this revision to Diff 143330. svenvh added a comment. Added a template class test as requested. https://reviews.llvm.org/D45873 Files: include/clang/Basic/DiagnosticParseKinds.td include/clang/Basic/LangOptions.def lib/Frontend/CompilerInvocation.cpp

[PATCH] D45873: [OpenCL] Reject virtual functions for OpenCL C++

yaxunl added inline comments. Comment at: test/Parser/opencl-cxx-virtual.cl:1 +// RUN: %clang_cc1 %s -triple spir-unknown-unknown -cl-std=c++ -fsyntax-only -verify + can you add a test for template class with virtual member? Repository: rC Clang

[PATCH] D45873: [OpenCL] Reject virtual functions for OpenCL C++

svenvh created this revision. svenvh added reviewers: yaxunl, bader. Herald added a subscriber: cfe-commits. The OpenCL C++ specification doesn't mention restricting virtual inheritance, so leaving that unaffected for now. Repository: rC Clang https://reviews.llvm.org/D45873 Files: