This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE332459: [clangd] Retrieve minimally formatted comment text
in completion. (authored by ibiryukov, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D45999?vs=147060=147063#toc
ilya-biryukov updated this revision to Diff 147060.
ilya-biryukov added a comment.
Rebase onto head, fix merge conflicts
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D45999
Files:
clangd/CodeComplete.cpp
clangd/CodeComplete.h
clangd/CodeCompletionStrings.cpp
ilya-biryukov added inline comments.
Comment at: clangd/CodeCompletionStrings.h:29
+
+/// Gets a raw documentation comment of the current active parameter
+/// of \p Result.
sammccall wrote:
> sammccall wrote:
> > ilya-biryukov wrote:
> > > ilya-biryukov wrote:
ilya-biryukov updated this revision to Diff 146827.
ilya-biryukov marked 6 inline comments as done.
ilya-biryukov added a comment.
- Fix code after a change in deps (getFormattedText now needs a SourceManager
instead of an ASTContext)
- Address review comments
Repository:
rCTE Clang Tools
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
Looks good, nits as always and I think you want a new test case.
Comment at: clangd/CodeComplete.cpp:817
Result.IncludeGlobals = true;
-
ilya-biryukov added inline comments.
Comment at: clangd/CodeCompletionStrings.h:24
+/// Gets a raw documentation comment of \p Result.
+/// Returns empty string when no comment is available.
sammccall wrote:
> What does raw mean - range of the file?
ilya-biryukov updated this revision to Diff 145883.
ilya-biryukov marked 4 inline comments as done.
ilya-biryukov added a comment.
- Renames and other comments
- Don't include brief comments in signature help either, comments there are
also handled by the code completion code now.
Repository:
sammccall added a comment.
My main question/concern is: if these APIs extract/format based on
CodeCompletionString and friends, what should our plan be using this this in
AST-based features, such as hover?
Comment at: clangd/CodeComplete.cpp:259
+
ilya-biryukov created this revision.
ilya-biryukov added reviewers: sammccall, hokein, ioeric.
Herald added subscribers: jkorous, MaskRay, klimek.
Previous implementation used to extract brief text from doxygen comments.
Brief text parsing slows down completion and is not suited for
non-doxygen
