This revision was automatically updated to reflect the committed changes.
Closed by commit rL331345: [analyzer] Add `TaintBugVisitor` to the
ArrayBoundV2, DivideZero and VLASize. (authored by henrywong, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://re
NoQ accepted this revision.
NoQ added a comment.
This revision is now accepted and ready to land.
Looks great, thanks!
I think the overall plan for any taint work would be to remove it from the
program state API and move getters/setters into its own translation unit (like
dynamic type propagati
MTC updated this revision to Diff 143908.
MTC marked an inline comment as done.
MTC added a comment.
Since `BugReport::addVisitor()` has checks for the null `Visitor`, remove the
checks before `BugReport->addVisitor()`.
Repository:
rC Clang
https://reviews.llvm.org/D46007
Files:
lib/Stati
MTC marked an inline comment as done.
MTC added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/VLASizeChecker.cpp:75
auto report = llvm::make_unique(*BT, os.str(), N);
+ report->addVisitor(std::move(Visitor));
report->addRange(SizeE->getSourceRange());
--
a.sidorin added a comment.
Mostly LG.
Comment at: lib/StaticAnalyzer/Checkers/VLASizeChecker.cpp:75
auto report = llvm::make_unique(*BT, os.str(), N);
+ report->addVisitor(std::move(Visitor));
report->addRange(SizeE->getSourceRange());
In this patch, som
MTC created this revision.
MTC added reviewers: NoQ, george.karpenkov, xazax.hun, a.sidorin.
Herald added subscribers: cfe-commits, rnkovacs, szepet.
Add `TaintBugVisitor` to the ArrayBoundV2, DivideZero, VLASize to be able to
indicate where the taint information originated from.
Repository:
