This revision was automatically updated to reflect the committed changes.
Closed by commit rL331344: [ASTImporter] Fix isa cast assert (authored by
szepet, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D46019
Files:
martong added a comment.
ping...
@xazax.hun could you please help me with the commit?
Repository:
rC Clang
https://reviews.llvm.org/D46019
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
martong added a comment.
Guys, I still don't have commit rights, could you please help me with the
commit? (I think one more good quality patch and then I could request commit
rights for myself ...)
Repository:
rC Clang
https://reviews.llvm.org/D46019
a.sidorin added a comment.
Confirming LGTM, no objections. Thank you!
Repository:
rC Clang
https://reviews.llvm.org/D46019
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
szepet accepted this revision.
szepet added a comment.
Yepp, pretty straightforward check for something we were not aware previously
(but unfortunately encountered it).
Repository:
rC Clang
https://reviews.llvm.org/D46019
___
cfe-commits
xazax.hun accepted this revision.
xazax.hun added a comment.
With a sufficiently detailed commit message, i.e.: what version of a project
should be cheked out and how the analyzer needs to be ivoked to reproduce the
problem I am ok with committing this without a test.
Repository:
rC Clang
a.sidorin added a comment.
> `E->getFoundDecl().getDecl()` can be null when a member expression does not
> involve lookup. (Note, it may involve a lookup in case of a using directive
> which refers to a member function in a base class template.)
Yes, a pretty weird example. Unfortunately, they
martong added a comment.
Hi Aleksei,
Thanks for the review.
We faced this assert during the CTU analysis of protobuf. We tried hard to
synthesize a minimal test example both by hand and by executing creduce on
multiple files. Unfortunately, we were unable to reduce to such a minimal
example,
a.sidorin accepted this revision.
a.sidorin added a comment.
This revision is now accepted and ready to land.
This LGTM, but could you please add a test?
Repository:
rC Clang
https://reviews.llvm.org/D46019
___
cfe-commits mailing list
martong created this revision.
martong added reviewers: a.sidorin, xazax.hun, szepet.
Herald added subscribers: cfe-commits, dkrupp, rnkovacs.
Do early return if we can't import the found decl for a member expr.
This follows the pre-existing scheme, e.g with E->getMemberDecl().
Repository:
rC
10 matches
Mail list logo