thakis added a comment.
Apologies for misspelling your last name :-(
Repository:
rCXXA libc++abi
https://reviews.llvm.org/D46056
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
thakis closed this revision.
thakis added a comment.
Landed in r331150:
http://llvm.org/viewvc/llvm-project?view=revision=331150
Repository:
rCXXA libc++abi
https://reviews.llvm.org/D46056
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
tzik added a comment.
rsmith: Thanks! I don't have the commit access to the repository. Could you
submit this for me?
Repository:
rCXXA libc++abi
https://reviews.llvm.org/D46056
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
This looks right to me.
Repository:
rCXXA libc++abi
https://reviews.llvm.org/D46056
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
tzik added a comment.
rsmith: Could you PTAL to this? This is an attempt to resolve
https://bugs.llvm.org/show_bug.cgi?id=34103.
Though we already have a way to bring back std::unexpected to libc++abi, we
currently don't apply it properly, IMO.
Repository:
rCXXA libc++abi
tzik created this revision.
tzik added reviewers: rsmith, thakis.
Herald added subscribers: cfe-commits, mgorny.
_LIBCPP_ENABLE_CXX17_REMOVED_UNEXPECTED_FUNCTIONS is currently used to
bring back std::unexpected, which is removed in C++17, but still needed
for libc++abi for backward compatibility.
