[PATCH] D46140: [coroutines] Add std::experimental::task type

lewissbaker marked an inline comment as done. lewissbaker added a comment. Gentle ping. Is there anything else people would like to see changed? Repository: rCXX libc++ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D46140/new/ https://reviews.llvm.org/D46140

[PATCH] D46140: [coroutines] Add std::experimental::task type

lewissbaker marked 3 inline comments as done. lewissbaker added inline comments. Comment at: include/experimental/task:160 +__get_allocator<_CharAlloc>(__pointer, __size); +_CharAlloc __allocatorOnStack = _VSTD::move(__allocatorInFrame); +

[PATCH] D46140: [coroutines] Add std::experimental::task type

lewissbaker updated this revision to Diff 192944. lewissbaker marked 6 inline comments as done. lewissbaker added a comment. This updated diff should address most of @CaseyCarter's review comments. For detailed changelog you can find individual changes here

[PATCH] D46140: [coroutines] Add std::experimental::task type

lewissbaker marked 40 inline comments as done. lewissbaker added a comment. Thanks very much for the detailed review @CaseyCarter! Very much appreciated :) Comment at: include/experimental/__memory:80 +{ +return (__s + __a - 1) & ~(__a - 1); +} CaseyCarter

[PATCH] D46140: [coroutines] Add std::experimental::task type

CaseyCarter requested changes to this revision. CaseyCarter added a subscriber: mclow.lists. CaseyCarter added inline comments. This revision now requires changes to proceed. Comment at: include/experimental/__memory:80 +{ +return (__s + __a - 1) & ~(__a - 1); +}

[PATCH] D46140: [coroutines] Add std::experimental::task type

lewissbaker marked an inline comment as done. lewissbaker added a comment. @EricWF This implementation will currently not work with MSVC as MSVC does not yet support the symmetric-transfer capability added to the coroutines specification in P0913R0 . Is MSVC a target

[PATCH] D46140: [coroutines] Add std::experimental::task type

lewissbaker updated this revision to Diff 192384. lewissbaker added a comment. Added missing 'require coroutines' for experimental/task entry in module.modulemap Added missing #include in experimental/task header that was failing module builds Repository: rCXX libc++ CHANGES SINCE LAST

[PATCH] D46140: [coroutines] Add std::experimental::task type

lewissbaker reopened this revision. lewissbaker added a comment. This revision is now accepted and ready to land. Reopening as the commit for this diff was reverted due to it breaking the buildbot module builds. Repository: rCXX libc++ CHANGES SINCE LAST ACTION

[PATCH] D46140: [coroutines] Add std::experimental::task type

modocache closed this revision. modocache added a comment. Committed in rL357010 . Apologies, I forgot to include the differential revision in the commit message so this diff wasn't closed automatically as a result. I'll comment on rL357010