[PATCH] D46374: Add support for ObjC property name to be a single acronym.

stephanemoore added a comment. Looks good to me. Repository: rL LLVM https://reviews.llvm.org/D46374 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D46374: Add support for ObjC property name to be a single acronym.

This revision was automatically updated to reflect the committed changes. Wizard marked an inline comment as done. Closed by commit rL331545: Add support for ObjC property name to be a single acronym. (authored by Wizard, committed by ). Herald added a subscriber: llvm-commits. Repository: rL

[PATCH] D46374: Add support for ObjC property name to be a single acronym.

Wizard marked an inline comment as done. Wizard added inline comments. Comment at: clang-tidy/objc/PropertyDeclarationCheck.cpp:222 + [MatchedDecl](std::string const ) { +auto Acronym = llvm::Regex("^" + s + "$"); +return

[PATCH] D46374: Add support for ObjC property name to be a single acronym.

Wizard updated this revision to Diff 145226. Wizard added a comment. optimize matching Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D46374 Files: clang-tidy/objc/PropertyDeclarationCheck.cpp test/clang-tidy/objc-property-declaration-custom.m

[PATCH] D46374: Add support for ObjC property name to be a single acronym.

benhamilton accepted this revision. benhamilton added inline comments. This revision is now accepted and ready to land. Comment at: clang-tidy/objc/PropertyDeclarationCheck.cpp:222 + [MatchedDecl](std::string const ) { +auto Acronym =

[PATCH] D46374: Add support for ObjC property name to be a single acronym.

Wizard marked 3 inline comments as done. Wizard added inline comments. Comment at: test/clang-tidy/objc-property-declaration.m:24 @property(assign, nonatomic) int enableGLAcceleration; +@property(assign, nonatomic) int ID; @end benhamilton wrote: > Please add

[PATCH] D46374: Add support for ObjC property name to be a single acronym.

Wizard updated this revision to Diff 145145. Wizard added a comment. resolve comments Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D46374 Files: clang-tidy/objc/PropertyDeclarationCheck.cpp test/clang-tidy/objc-property-declaration-custom.m

[PATCH] D46374: Add support for ObjC property name to be a single acronym.

Wizard added inline comments. Comment at: clang-tidy/objc/PropertyDeclarationCheck.cpp:222 + [MatchedDecl](std::string const ) { +return s == MatchedDecl->getName(); + })) { benhamilton wrote: > `s` is a

[PATCH] D46374: Add support for ObjC property name to be a single acronym.

benhamilton requested changes to this revision. benhamilton added inline comments. This revision now requires changes to proceed. Comment at: clang-tidy/objc/PropertyDeclarationCheck.cpp:222 + [MatchedDecl](std::string const ) { +return s ==

[PATCH] D46374: Add support for ObjC property name to be a single acronym.

Wizard updated this revision to Diff 144970. Wizard edited the summary of this revision. Wizard added a comment. fix format Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D46374 Files: clang-tidy/objc/PropertyDeclarationCheck.cpp test/clang-tidy/objc-property-declaration.m

[PATCH] D46374: Add support for ObjC property name to be a single acronym.

Wizard created this revision. Herald added subscribers: cfe-commits, klimek. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D46374 Files: clang-tidy/objc/PropertyDeclarationCheck.cpp test/clang-tidy/objc-property-declaration.m Index: