oso Lopes
> *Sent:* Wednesday, June 20, 2018 6:25 PM
> *To:* Stella Stamenova
> *Cc:* Richard Smith; Duncan Exon Smith; jkor...@apple.com; Michał Górny;
> cfe-commits
> *Subject:* Re: [PATCH] D46485: Add python tool to dump and construct
> header maps
>
> On Wed, Jun 20,
: Add python tool to dump and construct header maps
On Wed, Jun 20, 2018 at 5:42 PM Stella Stamenova wrote:
>
> Thanks Bruno,
>
> I ran a build as well and I can see that hmaptool is now in the correct bin
> directory. The tests still failed though because on Windows, at lea
, June 20, 2018 4:14 PM
To: Stella Stamenova
Cc: Richard Smith ; Duncan Exon Smith
; jkor...@apple.com; mgo...@gentoo.org; cfe-commits
Subject: Re: [PATCH] D46485: Add python tool to dump and construct header maps
Attempted a fix in r335190, watching the bots.
On Wed, Jun 20, 2018 at 3:53 PM Brun
On Wed, Jun 20, 2018 at 5:42 PM Stella Stamenova wrote:
>
> Thanks Bruno,
>
> I ran a build as well and I can see that hmaptool is now in the correct bin
> directory. The tests still failed though because on Windows, at least, you
> need to explicitly call python to run a script e.g. "python
Attempted a fix in r335190, watching the bots.
On Wed, Jun 20, 2018 at 3:53 PM Bruno Cardoso Lopes
wrote:
>
> Hi Stella,
>
> On Wed, Jun 20, 2018 at 3:44 PM Stella Stamenova via Phabricator
> wrote:
> >
> > stella.stamenova added a comment.
> >
> > This breaks the clang tests on Windows when
Hi Stella,
On Wed, Jun 20, 2018 at 3:44 PM Stella Stamenova via Phabricator
wrote:
>
> stella.stamenova added a comment.
>
> This breaks the clang tests on Windows when building using Visual Studio as
> none of the updated tests can find hmaptool.
Yes. I contacted Galina about that but maybe
stella.stamenova added a comment.
This breaks the clang tests on Windows when building using Visual Studio as
none of the updated tests can find hmaptool.
Visual Studio as a generator supports multiple configurations, so its bin
folder varies depending on the build configuration. The
This revision was automatically updated to reflect the committed changes.
Closed by commit rC335177: Add python tool to dump and construct header maps
(authored by bruno, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D46485?vs=152142=152168#toc
Repository:
rC Clang
bruno updated this revision to Diff 152142.
bruno added a comment.
Update after Richard's review, fix python3 compatibility and check for zero
sized string table
https://reviews.llvm.org/D46485
Files:
CMakeLists.txt
test/CMakeLists.txt
test/Modules/crash-vfs-headermaps.m
rsmith accepted this revision.
rsmith added inline comments.
This revision is now accepted and ready to land.
Comment at: utils/hmaptool/hmaptool:1
+#!/usr/bin/env python
+
Have you checked this works with both python2 and python3?
Comment at:
bruno added a comment.
Ping.
Without this patch, we would have to add binary header maps for tests in
https://reviews.llvm.org/D47157 and https://reviews.llvm.org/D47301, which I
would like to avoid.
https://reviews.llvm.org/D46485
___
bruno added a comment.
Ping!
https://reviews.llvm.org/D46485
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bruno updated this revision to Diff 147901.
bruno added a comment.
Remove more outdated comments
https://reviews.llvm.org/D46485
Files:
CMakeLists.txt
test/CMakeLists.txt
test/Modules/crash-vfs-headermaps.m
test/Preprocessor/Inputs/headermap-rel/foo.hmap
dexonsmith added a comment.
Removing the binary header map files is a clear win, but I'd like someone else
to approve this.
Comment at: test/Preprocessor/headermap-rel2.c:1-2
// This uses a headermap with this entry:
// someheader.h -> Product/someheader.h
bruno updated this revision to Diff 147829.
bruno added a comment.
Update testcases (and fixed a missing one) after Duncan's review.
https://reviews.llvm.org/D46485
Files:
CMakeLists.txt
test/CMakeLists.txt
test/Modules/crash-vfs-headermaps.m
bruno added inline comments.
Comment at: test/Preprocessor/headermap-rel.c:2-3
// This uses a headermap with this entry:
// Foo.h -> Foo/Foo.h
dexonsmith wrote:
> Should we delete this comment now that the header map is human-readable?
Sure!
dexonsmith added inline comments.
Comment at: test/Preprocessor/headermap-rel.c:2-3
// This uses a headermap with this entry:
// Foo.h -> Foo/Foo.h
Should we delete this comment now that the header map is human-readable?
Comment at:
jkorous added a comment.
LGTM but my review was fairly superficial.
Comment at: utils/hmaptool/hmaptool:55
+# The number of buckets must be a power of two.
+if num_buckets == 0 or (num_buckets & num_buckets - 1) != 0:
+raise
bruno updated this revision to Diff 146992.
bruno added a comment.
Update after Jan review.
https://reviews.llvm.org/D46485
Files:
CMakeLists.txt
test/CMakeLists.txt
test/Preprocessor/Inputs/headermap-rel/foo.hmap
test/Preprocessor/Inputs/headermap-rel/foo.hmap.json
bruno marked an inline comment as done.
bruno added inline comments.
Comment at: utils/hmaptool/hmaptool:55
+# The number of buckets must be a power of two.
+if num_buckets == 0 or (num_buckets & num_buckets - 1) != 0:
+raise
bruno added a comment.
@jkorous, thanks for taking a look. This is an old python script which I
haven't touched before, maybe there were answers to your questions but they are
now lost in time. I'll address the review though and upload a new version.
Repository:
rC Clang
jkorous added a comment.
Hi Bruno, I just noticed couple of implementation details.
Comment at: utils/hmaptool/hmaptool:55
+# The number of buckets must be a power of two.
+if num_buckets == 0 or (num_buckets & num_buckets - 1) != 0:
+
bruno added a comment.
Ping
Repository:
rC Clang
https://reviews.llvm.org/D46485
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bruno added a comment.
Ping!
Repository:
rC Clang
https://reviews.llvm.org/D46485
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bruno created this revision.
bruno added a reviewer: rsmith.
Herald added a subscriber: mgorny.
Header maps are binary files used by Xcode, which are used to map
header names or paths to other locations. Clang has support for
those since its inception, but there's not a lot of header map
testing
25 matches
Mail list logo
