[PATCH] D46791: Make -gsplit-dwarf generally available

pcc added a comment. Correct, clang no longer uses objcopy for this as of D47093 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D46791/new/ https://reviews.llvm.org/D46791 ___ cfe-commits mailing list

[PATCH] D46791: Make -gsplit-dwarf generally available

emaste added a comment. Herald added a subscriber: arichardson. running `clang -target x86_64-unknown-freebsd13.0 -split-dwarf foo.c` indeed produces a foo.dwo and foo.o w/o invoking objcopy CHANGES SINCE LAST ACTION https://reviews.llvm.org/D46791/new/ https://reviews.llvm.org/D46791

[PATCH] D46791: Make -gsplit-dwarf generally available

jakehehrlich added a comment. This is obsolete I think. Clang doesn't use llvm-objcopy for this anymore if I understand correct. @pcc should be able to confirm. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D46791/new/ https://reviews.llvm.org/D46791

[PATCH] D46791: Make -gsplit-dwarf generally available

aprantl added inline comments. Comment at: test/Driver/split-debug.c:28 +// MACOSX-CHECK-ACTIONS: objcopy{{.*}}--extract-dwo{{.*}}"split-debug.dwo" +// MACOSX-CHECK-ACTIONS: objcopy{{.*}}--strip-dwo{{.*}}"split-debug.o" split dwarf does not make sense on macOS

[PATCH] D46791: Make -gsplit-dwarf generally available

emaste added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D46791/new/ https://reviews.llvm.org/D46791 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D46791: Make -gsplit-dwarf generally available

compnerd added inline comments. Comment at: test/Driver/split-debug.c:23 +// Macosx // RUN: %clang -target x86_64-macosx -gsplit-dwarf -c -### %s 2> %t NIT: macOS or the legacy spelling of Mac OS X. https://reviews.llvm.org/D46791

[PATCH] D46791: Make -gsplit-dwarf generally available

echristo added a comment. In https://reviews.llvm.org/D46791#1107168, @pcc wrote: > There were a bunch of them but the last one was > https://reviews.llvm.org/D47093 which has already landed :) > > Probably all that needs to happen on this change is to replace the isLinux() > check with

[PATCH] D46791: Make -gsplit-dwarf generally available

pcc added a comment. There were a bunch of them but the last one was https://reviews.llvm.org/D47093 which has already landed :) Probably all that needs to happen on this change is to replace the isLinux() check with isELF(). https://reviews.llvm.org/D46791

[PATCH] D46791: Make -gsplit-dwarf generally available

jakehehrlich added a comment. Yeah I haven't heard back from Lexan nor have I tried reproducing such a build myself and if we're that close to not relaying on this sort of hack I'd much rather wait on this than risk breaking someone for the sake of a stopgap for such a short period of time.

[PATCH] D46791: Make -gsplit-dwarf generally available

echristo added subscribers: pcc, paulsemel. echristo added a comment. FWIW Peter has some patches to move object emission away from objcopy that I'm on the hook to review here shortly so the objcopy part of this should become unnecessary and can just have us able to emit dwarf5 compatible split

[PATCH] D46791: Make -gsplit-dwarf generally available

trixirt updated this revision to Diff 146970. trixirt added a comment. Improve comment in CLANG_DEFAULT_OBJCOPY to specify what is required of objcopy. Remove the llvm- prefix from testing to allow for override of default value. https://reviews.llvm.org/D46791 Files: CMakeLists.txt

[PATCH] D46791: Make -gsplit-dwarf generally available

jakehehrlich added a comment. I'm generally ok with this but I think some important checks need to occur first. Namely I think I'd like to check that Chromium still builds with this option since I'd imagine they'd be affected by this. Repository: rC Clang https://reviews.llvm.org/D46791

[PATCH] D46791: Make -gsplit-dwarf generally available

jakehehrlich added inline comments. Comment at: lib/Driver/ToolChains/Clang.cpp:4818 // Handle the debug info splitting at object creation time if we're // creating an object. if (SplitDWARF && Output.getType() == types::TY_Object) Maybe re-add a TODO

[PATCH] D46791: Make -gsplit-dwarf generally available

trixirt created this revision. trixirt added reviewers: echristo, jakehehrlich, emaste. Herald added subscribers: cfe-commits, JDevlieghere, krytarowski, aprantl, mgorny. Herald added a reviewer: alexshap. Change CLANG_DEFAULT_OBJCOPY from objcopy to llvm-objcopy Remove is-linux checks Add dwarf