[PATCH] D46919: [libclang] Deprecate CXPrintingPolicy_IncludeTagDefinition

jdenny updated this revision to Diff 166992. jdenny set the repository for this revision to rC Clang. jdenny added a comment. Ping. Rebased. This patch intends to perform cleanup that @rsmith suggested while reviewing another patch from me. If there's no more interest, it's fine with me to

[PATCH] D46919: [libclang] Deprecate CXPrintingPolicy_IncludeTagDefinition

jdenny updated this revision to Diff 156620. jdenny added a comment. Ping. Rebased. https://reviews.llvm.org/D46919 Files: clang/include/clang-c/Index.h clang/include/clang/AST/PrettyPrinter.h clang/lib/AST/DeclPrinter.cpp clang/lib/AST/TypePrinter.cpp

[PATCH] D46919: [libclang] Deprecate CXPrintingPolicy_IncludeTagDefinition

jdenny updated this revision to Diff 153930. jdenny added a comment. Ping. Rebased. https://reviews.llvm.org/D46919 Files: include/clang-c/Index.h include/clang/AST/PrettyPrinter.h lib/AST/DeclPrinter.cpp lib/AST/TypePrinter.cpp tools/c-index-test/c-index-test.c Index:

[PATCH] D46919: [libclang] Deprecate CXPrintingPolicy_IncludeTagDefinition

jdenny updated this revision to Diff 151979. jdenny added a comment. Rebased. Ping. https://reviews.llvm.org/D46919 Files: include/clang-c/Index.h include/clang/AST/PrettyPrinter.h lib/AST/DeclPrinter.cpp lib/AST/TypePrinter.cpp tools/c-index-test/c-index-test.c Index:

[PATCH] D46919: [libclang] Deprecate CXPrintingPolicy_IncludeTagDefinition

jdenny added a comment. In https://reviews.llvm.org/D46919#1107296, @rsmith wrote: > In https://reviews.llvm.org/D46919#1101268, @jdenny wrote: > > > In https://reviews.llvm.org/D46919#1100493, @rsmith wrote: > > > > > The deprecated enumerator is also referenced by > > >

[PATCH] D46919: [libclang] Deprecate CXPrintingPolicy_IncludeTagDefinition

rsmith added a comment. In https://reviews.llvm.org/D46919#1101268, @jdenny wrote: > In https://reviews.llvm.org/D46919#1100493, @rsmith wrote: > > > The deprecated enumerator is also referenced by > > `tools/c-index-test/c-index-test.c` > > > This test prompted me to keep the

[PATCH] D46919: [libclang] Deprecate CXPrintingPolicy_IncludeTagDefinition

jdenny added a comment. In https://reviews.llvm.org/D46919#1101268, @jdenny wrote: > In https://reviews.llvm.org/D46919#1100493, @rsmith wrote: > > > The deprecated enumerator is also referenced by > > `tools/c-index-test/c-index-test.c` > > > This test prompted me to keep the

[PATCH] D46919: [libclang] Deprecate CXPrintingPolicy_IncludeTagDefinition

jdenny updated this revision to Diff 147887. jdenny marked 2 inline comments as done. jdenny edited the summary of this revision. jdenny added a comment. Made a stab at the suggested changes. https://reviews.llvm.org/D46919 Files: include/clang-c/Index.h include/clang/AST/PrettyPrinter.h

[PATCH] D46919: [libclang] Deprecate CXPrintingPolicy_IncludeTagDefinition

jdenny added a comment. In https://reviews.llvm.org/D46919#1100493, @rsmith wrote: > The deprecated enumerator is also referenced by > `tools/c-index-test/c-index-test.c` This test prompted me to keep the IncludeTagDefinition member in PrintingPolicy so that clang_PrintingPolicy_getProperty

[PATCH] D46919: [libclang] Deprecate CXPrintingPolicy_IncludeTagDefinition

rsmith added a comment. The deprecated enumerator is also referenced by `tools/c-index-test/c-index-test.c` This looks fine to me, but let's leave this review thread open for a week or so, to give people a bit more time to object in case they're using the flag for something.

[PATCH] D46919: [libclang] Deprecate CXPrintingPolicy_IncludeTagDefinition

jdenny created this revision. jdenny added a reviewer: rsmith. And make it have no effect. Suggested at: https://reviews.llvm.org/D45463#1096629 I'm not sure of the proper way to deprecate something in libclang. Let me know if something else is needed. https://reviews.llvm.org/D46919 Files: