gramanas updated this revision to Diff 150357.
gramanas added a comment.
Make more elaborate comment.
Repository:
rC Clang
https://reviews.llvm.org/D47097
Files:
lib/CodeGen/CGDecl.cpp
test/CodeGen/debug-info-preserve-scope.c
Index: test/CodeGen/debug-info-preserve-scope.c
aprantl added inline comments.
Comment at: lib/CodeGen/CGDecl.cpp:1949
+ // Set artificial debug location in order to preserve the scope
+ auto DL = ApplyDebugLocation::CreateArtificial(*this);
Can you make that comment elaborate more about why this is being
gramanas added a comment.
What about this? Ping!
Repository:
rC Clang
https://reviews.llvm.org/D47097
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
gramanas updated this revision to Diff 148588.
gramanas added a comment.
I added a test that illustrates what @vsk is talking about.
Sorry for not providing the relevant information but I thought this would
be a simple one liner like https://reviews.llvm.org/rL327800. I will update the
vsk added a comment.
In https://reviews.llvm.org/D47097#248, @aprantl wrote:
> In https://reviews.llvm.org/D47097#223, @gramanas wrote:
>
> > In https://reviews.llvm.org/D47097#149, @probinson wrote:
> >
> > > Can we step back a second and better explain what the problem is? With
>
aprantl added a comment.
In https://reviews.llvm.org/D47097#223, @gramanas wrote:
> In https://reviews.llvm.org/D47097#149, @probinson wrote:
>
> > Can we step back a second and better explain what the problem is? With
> > current Clang the debug info for this function looks okay to me.
gramanas added a comment.
In https://reviews.llvm.org/D47097#149, @probinson wrote:
> Can we step back a second and better explain what the problem is? With
> current Clang the debug info for this function looks okay to me.
> The store that is "missing" a debug location is homing the
probinson added a comment.
Can we step back a second and better explain what the problem is? With current
Clang the debug info for this function looks okay to me.
The store that is "missing" a debug location is homing the formal parameter to
its local stack location; this is part of prolog
gramanas updated this revision to Diff 148414.
gramanas added a comment.
Adress review comments.
Limit changes to the storeInst
Repository:
rC Clang
https://reviews.llvm.org/D47097
Files:
lib/CodeGen/CGDecl.cpp
test/CodeGen/debug-info-preserve-scope.c
Index:
aprantl added inline comments.
Comment at: lib/CodeGen/CGExpr.cpp:72
+ // Set debug location in order to preserve the scope
+ Alloca->setDebugLoc(Builder.getCurrentDebugLocation());
if (AllocaAddr)
vsk wrote:
> aprantl wrote:
> > vsk wrote:
> > > aprantl
vsk added inline comments.
Comment at: lib/CodeGen/CGExpr.cpp:72
+ // Set debug location in order to preserve the scope
+ Alloca->setDebugLoc(Builder.getCurrentDebugLocation());
if (AllocaAddr)
aprantl wrote:
> vsk wrote:
> > aprantl wrote:
> > > vsk wrote:
aprantl added inline comments.
Comment at: lib/CodeGen/CGExpr.cpp:72
+ // Set debug location in order to preserve the scope
+ Alloca->setDebugLoc(Builder.getCurrentDebugLocation());
if (AllocaAddr)
vsk wrote:
> aprantl wrote:
> > vsk wrote:
> > > I think we
vsk added inline comments.
Comment at: lib/CodeGen/CGExpr.cpp:72
+ // Set debug location in order to preserve the scope
+ Alloca->setDebugLoc(Builder.getCurrentDebugLocation());
if (AllocaAddr)
aprantl wrote:
> vsk wrote:
> > I think we need to be a bit
aprantl added inline comments.
Comment at: lib/CodeGen/CGExpr.cpp:72
+ // Set debug location in order to preserve the scope
+ Alloca->setDebugLoc(Builder.getCurrentDebugLocation());
if (AllocaAddr)
vsk wrote:
> I think we need to be a bit more careful here.
vsk added inline comments.
Comment at: lib/CodeGen/CGExpr.cpp:72
+ // Set debug location in order to preserve the scope
+ Alloca->setDebugLoc(Builder.getCurrentDebugLocation());
if (AllocaAddr)
I think we need to be a bit more careful here. The current
gramanas updated this revision to Diff 148200.
gramanas marked an inline comment as done.
gramanas added a comment.
Remove redundant `this`
Repository:
rC Clang
https://reviews.llvm.org/D47097
Files:
lib/CodeGen/CGDecl.cpp
lib/CodeGen/CGExpr.cpp
gramanas updated this revision to Diff 148198.
gramanas added a comment.
Set debug location to the entry block alloca
Repository:
rC Clang
https://reviews.llvm.org/D47097
Files:
lib/CodeGen/CGDecl.cpp
lib/CodeGen/CGExpr.cpp
test/CodeGen/debug-info-preserve-scope.c
Index:
vsk added inline comments.
Comment at: test/CodeGen/debug-info-preserve-scope.c:10
+
+// CHECK: alloca i32 {{.*}} !dbg ![[dbgLocForStore:[0-9]+]]
+// CHECK: store i32 {{.*}} !dbg ![[dbgLocForStore:[0-9]+]]
In these two check lines, you're capturing the variable
gramanas updated this revision to Diff 148034.
gramanas added a comment.
Move ApplyDebugLocation before CreateMemTemp
Repository:
rC Clang
https://reviews.llvm.org/D47097
Files:
lib/CodeGen/CGDecl.cpp
test/CodeGen/debug-info-preserve-scope.c
Index:
vsk added inline comments.
Comment at: lib/CodeGen/CGDecl.cpp:2074
+ if (DoStore) {
+ auto DL = ApplyDebugLocation::CreateArtificial(*this);
+ EmitStoreOfScalar(ArgVal, lv, /* isInitialization */ true);
Ideally this would precede the calls to CreateMemTemp
gramanas updated this revision to Diff 147876.
gramanas added a comment.
Update diff
Repository:
rC Clang
https://reviews.llvm.org/D47097
Files:
lib/CodeGen/CGDecl.cpp
test/CodeGen/debug-info-preserve-scope.c
Index: test/CodeGen/debug-info-preserve-scope.c
21 matches
Mail list logo
