malcolm.parsons added inline comments.
Comment at:
clang-tools-extra/trunk/clang-tidy/readability/SimplifyBooleanExprCheck.cpp:198
E = E->ignoreParenBaseCasts();
+ if (const auto *EC = dyn_cast(E))
+E = EC->getSubExpr();
zinovy.nis wrote:
> zinovy.nis
zinovy.nis added inline comments.
Comment at:
clang-tools-extra/trunk/clang-tidy/readability/SimplifyBooleanExprCheck.cpp:198
E = E->ignoreParenBaseCasts();
+ if (const auto *EC = dyn_cast(E))
+E = EC->getSubExpr();
zinovy.nis wrote:
> malcolm.parsons
zinovy.nis added inline comments.
Comment at:
clang-tools-extra/trunk/clang-tidy/readability/SimplifyBooleanExprCheck.cpp:198
E = E->ignoreParenBaseCasts();
+ if (const auto *EC = dyn_cast(E))
+E = EC->getSubExpr();
malcolm.parsons wrote:
>
malcolm.parsons added inline comments.
Comment at:
clang-tools-extra/trunk/clang-tidy/readability/SimplifyBooleanExprCheck.cpp:198
E = E->ignoreParenBaseCasts();
+ if (const auto *EC = dyn_cast(E))
+E = EC->getSubExpr();
`E->IgnoreImplicit()` can be
This revision was automatically updated to reflect the committed changes.
Closed by commit rL333003: [clang-tidy] SimplifyBoolenExpr doesnt add
parens if unary negotiation is of… (authored by zinovy.nis, committed by ).
Herald added subscribers: llvm-commits, klimek.
Changed prior to commit:
zinovy.nis updated this revision to Diff 147836.
zinovy.nis edited the summary of this revision.
zinovy.nis added a comment.
- More accurate place to fix.
https://reviews.llvm.org/D47122
Files:
clang-tidy/readability/SimplifyBooleanExprCheck.cpp
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM, with a small nit.
Comment at: clang-tidy/readability/SimplifyBooleanExprCheck.cpp:78
E = E->IgnoreImpCasts();
+ if (auto *EC = dyn_cast(E))
+E =
zinovy.nis created this revision.
zinovy.nis added reviewers: alexfh, aaron.ballman.
zinovy.nis added a project: clang-tools-extra.
Herald added subscribers: cfe-commits, xazax.hun.
using A = std::string;
bool foo(A ) {
A S;
if (GetValue(s) && S != (A)s)
return false;
return
