[PATCH] D47400: [libcxx] [test] Allow a standard library that implements LWG 1203 in istream.rvalue/rvalue.pass.cpp

2018-08-09 Thread Louis Dionne via Phabricator via cfe-commits
ldionne accepted this revision. ldionne added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D47400 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D47400: [libcxx] [test] Allow a standard library that implements LWG 1203 in istream.rvalue/rvalue.pass.cpp

2018-08-07 Thread Billy Robert O'Neal III via Phabricator via cfe-commits
BillyONeal added a reviewer: ldionne. BillyONeal added a comment. Adding ldionne as suggested by Eric. https://reviews.llvm.org/D47400 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D47400: [libcxx] [test] Allow a standard library that implements LWG 1203 in istream.rvalue/rvalue.pass.cpp

2018-08-07 Thread Billy Robert O'Neal III via Phabricator via cfe-commits
BillyONeal added a comment. Committed r339214 (If there are changes requested I'll do them in a follow up commit) https://reviews.llvm.org/D47400 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D47400: [libcxx] [test] Allow a standard library that implements LWG 1203 in istream.rvalue/rvalue.pass.cpp

2018-05-25 Thread Billy Robert O'Neal III via Phabricator via cfe-commits
BillyONeal created this revision. BillyONeal added reviewers: EricWF, mclow.lists. If a standard library implements LWG 1203 (which I am implementing in MSVC++ right now) the return value of (istringstream() << A{}) is an rvalue, so it can't have an lvalue reference bound to it. Change this