This revision was automatically updated to reflect the committed changes.
LukeGeeson marked an inline comment as done.
Closed by commit rL334489: [AArch64] Corrected FP16 Intrinsic range checks in
Clang + added Sema tests (authored by LukeGeeson, committed by ).
Herald added a subscriber: llvm-com
SjoerdMeijer accepted this revision.
SjoerdMeijer added a comment.
This revision is now accepted and ready to land.
I think this looks ok now, just some nits inline.
Can you please upload your diffs with more context next time?
Comment at: utils/TableGen/NeonEmitter.cpp:2166
+
LukeGeeson marked 2 inline comments as done.
LukeGeeson added inline comments.
Comment at: lib/Sema/SemaChecking.cpp:1409
- switch (BuiltinID) {
-#define GET_NEON_OVERLOAD_CHECK
-#include "clang/Basic/arm_neon.inc"
SjoerdMeijer wrote:
> Why do we need to remove
LukeGeeson updated this revision to Diff 149737.
LukeGeeson marked an inline comment as done.
LukeGeeson added a comment.
-generates range checks in NEON Emitter rather than hardcoding in
SemaChecking.cpp
-uses 'isVCVT_N' to correctly direct the emitter to generate the correct ranges.
https://r
SjoerdMeijer added inline comments.
Comment at: lib/Sema/SemaChecking.cpp:1409
- switch (BuiltinID) {
-#define GET_NEON_OVERLOAD_CHECK
-#include "clang/Basic/arm_neon.inc"
Why do we need to remove this?
Comment at: lib/Sema/SemaChecking.cpp:14
SjoerdMeijer added inline comments.
Comment at: test/Sema/aarch64-neon-fp16-ranges.c:1
+// RUN: %clang_cc1 -triple arm64-linux-gnu -target-feature +neon
-fallow-half-arguments-and-returns -target-feature +fullfp16 -ffreestanding
-fsyntax-only -verify %s
+// RUN: %clang_cc1 -tri
LukeGeeson created this revision.
LukeGeeson added a reviewer: SjoerdMeijer.
Herald added a reviewer: javed.absar.
Herald added a subscriber: kristof.beyls.
This fixes the ranges for the vcvth family of FP16 intrinsics in the clang
front end. Previously it was accepting incorrect ranges
-Changed
