[PATCH] D47843: Introducing single for loop into clang_proto_fuzzer

2018-06-07 Thread Vitaly Buka via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL334216: Introducing single for loop into clang_proto_fuzzer (authored by vitalybuka, committed by ). Repository: rL LLVM https://reviews.llvm.org/D47843 Files:

[PATCH] D47843: Introducing single for loop into clang_proto_fuzzer

2018-06-07 Thread Vitaly Buka via Phabricator via cfe-commits
vitalybuka updated this revision to Diff 150380. vitalybuka added a comment. git clang-format -f --style=file HEAD^ Repository: rC Clang https://reviews.llvm.org/D47843 Files: tools/clang-fuzzer/CMakeLists.txt tools/clang-fuzzer/ExampleClangLoopProtoFuzzer.cpp

[PATCH] D47843: Introducing single for loop into clang_proto_fuzzer

2018-06-07 Thread Emmett Neyman via Phabricator via cfe-commits
emmettneyman updated this revision to Diff 150365. emmettneyman added a comment. - refactored cmake and deleted header file Repository: rC Clang https://reviews.llvm.org/D47843 Files: tools/clang-fuzzer/CMakeLists.txt tools/clang-fuzzer/ExampleClangLoopProtoFuzzer.cpp

[PATCH] D47843: Introducing single for loop into clang_proto_fuzzer

2018-06-06 Thread Matt Morehouse via Phabricator via cfe-commits
morehouse added inline comments. Comment at: tools/clang-fuzzer/CMakeLists.txt:28 protobuf_generate_cpp(PROTO_SRCS PROTO_HDRS cxx_proto.proto) + protobuf_generate_cpp(PROTO_SRCS PROTO_HDRS cxx_loop_proto.proto) set(LLVM_OPTIONAL_SOURCES ${LLVM_OPTIONAL_SOURCES}

[PATCH] D47843: Introducing single for loop into clang_proto_fuzzer

2018-06-06 Thread Emmett Neyman via Phabricator via cfe-commits
emmettneyman updated this revision to Diff 150213. emmettneyman added a comment. - Combined two header files into one Repository: rC Clang https://reviews.llvm.org/D47843 Files: tools/clang-fuzzer/CMakeLists.txt tools/clang-fuzzer/ExampleClangLoopProtoFuzzer.cpp

[PATCH] D47843: Introducing single for loop into clang_proto_fuzzer

2018-06-06 Thread Matt Morehouse via Phabricator via cfe-commits
morehouse added inline comments. Comment at: tools/clang-fuzzer/cxx_loop_proto.proto:93 + +message Function { + required StatementSeq statements = 1; Maybe call this `LoopFunction` to distinguish from the other protobuf. Comment at:

[PATCH] D47843: Introducing single for loop into clang_proto_fuzzer

2018-06-06 Thread Emmett Neyman via Phabricator via cfe-commits
emmettneyman updated this revision to Diff 150200. emmettneyman added a comment. Hopefully rebased correctly. Repository: rC Clang https://reviews.llvm.org/D47843 Files: tools/clang-fuzzer/CMakeLists.txt tools/clang-fuzzer/ExampleClangLoopProtoFuzzer.cpp

[PATCH] D47843: Introducing single for loop into clang_proto_fuzzer

2018-06-06 Thread Matt Morehouse via Phabricator via cfe-commits
morehouse added a comment. This contains changes from previous patch. Please rebase. Repository: rC Clang https://reviews.llvm.org/D47843 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D47843: Introducing single for loop into clang_proto_fuzzer

2018-06-06 Thread Vitaly Buka via Phabricator via cfe-commits
vitalybuka requested changes to this revision. vitalybuka added inline comments. This revision now requires changes to proceed. Comment at: tools/clang-fuzzer/fuzzer-initialize/fuzzer_initialize.cpp:23 + +namespace clang_fuzzer { + I guess you already committed

[PATCH] D47843: Introducing single for loop into clang_proto_fuzzer

2018-06-06 Thread Emmett Neyman via Phabricator via cfe-commits
emmettneyman updated this revision to Diff 150192. emmettneyman added a comment. Took out typo'd comment Repository: rC Clang https://reviews.llvm.org/D47843 Files: tools/clang-fuzzer/CMakeLists.txt tools/clang-fuzzer/ExampleClangLoopProtoFuzzer.cpp

[PATCH] D47843: Introducing single for loop into clang_proto_fuzzer

2018-06-06 Thread Emmett Neyman via Phabricator via cfe-commits
emmettneyman created this revision. emmettneyman added reviewers: kcc, vitalybuka, morehouse. Herald added subscribers: cfe-commits, mgorny. Created a new protobuf and protobuf-to-C++ "converter" that wraps the entire C++ code in a single for loop. - Slightly changed cxx_proto.proto ->