This revision was automatically updated to reflect the committed changes.
Closed by commit rL336898: [ASTImporter] Fix infinite recursion on function
import with struct definition… (authored by martong, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
gerazo added a comment.
@martong I don't have commit rights. Thanks for your help in advance.
https://reviews.llvm.org/D47946
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
martong added a comment.
@gerazo, Do you have commit rights, or should I help with the commit?
https://reviews.llvm.org/D47946
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
gerazo updated this revision to Diff 154991.
gerazo marked an inline comment as done.
gerazo added a comment.
Minor fixes for Aleksei's comments.
https://reviews.llvm.org/D47946
Files:
lib/AST/ASTImporter.cpp
unittests/AST/ASTImporterTest.cpp
Index: unittests/AST/ASTImporterTest.cpp
gerazo marked 2 inline comments as done.
gerazo added inline comments.
Comment at: unittests/AST/ASTImporterTest.cpp:234
+assert(ToAST);
+createVirtualFileIfNeeded(ToAST.get(), It->FileName, It->Code);
+return &*It;
a.sidorin wrote:
> Can we move the
a.sidorin accepted this revision.
a.sidorin added a comment.
Hello Zoltán,
Sorry for the delay. I think the patch is fine, just some minor nits inline.
Comment at: unittests/AST/ASTImporterTest.cpp:234
+assert(ToAST);
+createVirtualFileIfNeeded(ToAST.get(),
martong added a comment.
Ping.
https://reviews.llvm.org/D47946
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
