This revision was automatically updated to reflect the committed changes.
Closed by commit rL342393: [clang-tidy] fix PR37913, templated exception
factory diagnosed correctly (authored by JonasToth, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
JonasToth updated this revision to Diff 165756.
JonasToth added a comment.
get up to date to master
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D48714
Files:
clang-tidy/hicpp/ExceptionBaseclassCheck.cpp
test/clang-tidy/hicpp-exception-baseclass.cpp
Index:
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG
Comment at: test/clang-tidy/hicpp-exception-baseclass.cpp:191
+void templated_thrower() { throw T{}(); }
+// CHECK-MESSAGES: [[@LINE-1]]:34: warning: throwing an
JonasToth marked 9 inline comments as done.
JonasToth added a comment.
I do consider the diagnostic thing as resolved given the lack of further
comments.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D48714
___
cfe-commits mailing
JonasToth added a comment.
I added more testcases for templates and improved the diagnostics with notes.
This includes newly discovered false positives related to uninstantiated
templates.
@alexfh, @hokein Would you like to see better diagnostics?
Repository:
rCTE Clang Tools Extra
JonasToth updated this revision to Diff 164721.
JonasToth added a comment.
- use the global ASTMatchers for dependent expressions
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D48714
Files:
clang-tidy/hicpp/ExceptionBaseclassCheck.cpp
JonasToth updated this revision to Diff 164690.
JonasToth added a comment.
- Fix typedependant expressions are ignored
This one took me way longer then it should have, but I discovered new templated
code constructs and added test accordingly.
Repository:
rCTE Clang Tools Extra
JonasToth updated this revision to Diff 163274.
JonasToth added a comment.
- [Misc] migrate to CHECK-NOTES
- fix outcommented check messages as well
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D48714
Files:
clang-tidy/hicpp/ExceptionBaseclassCheck.cpp
JonasToth added a comment.
In https://reviews.llvm.org/D48714#1216989, @lebedev.ri wrote:
> In https://reviews.llvm.org/D48714#1216537, @JonasToth wrote:
>
> > I had to revert the `CHECK-NOTES` change that @lebedev.ri introduced with
> > his revision. It fails the test, i think there is an
lebedev.ri added a comment.
In https://reviews.llvm.org/D48714#1216537, @JonasToth wrote:
> I had to revert the `CHECK-NOTES` change that @lebedev.ri introduced with his
> revision. It fails the test, i think there is an inconsistency or so in the
> check-clang-tidy script. I will try to
JonasToth updated this revision to Diff 162950.
JonasToth added a comment.
- [Test] use CHECK-NOTES again based on the fix in check_clang_tidy
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D48714
Files:
clang-tidy/hicpp/ExceptionBaseclassCheck.cpp
JonasToth added a subscriber: lebedev.ri.
JonasToth added a comment.
I had to revert the `CHECK-NOTES` change that @lebedev.ri introduced with his
revision. It fails the test, i think there is an inconsistency or so in the
check-clang-tidy script. I will try to figure out whats the issue.
JonasToth updated this revision to Diff 162945.
JonasToth added a comment.
- [Misc] comment the matcher to better understand it
- [Fix] adjust the test cases to properly function now
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D48714
Files:
aaron.ballman added inline comments.
Comment at: clang-tidy/hicpp/ExceptionBaseclassCheck.cpp:30-32
+ anyOf(has(expr(hasType(
+substTemplateTypeParmType().bind("templ_type",
+anything()),
This is a
JonasToth updated this revision to Diff 162448.
JonasToth added a comment.
- Merge branch 'master' into fix_exception
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D48714
Files:
clang-tidy/hicpp/ExceptionBaseclassCheck.cpp
test/clang-tidy/hicpp-exception-baseclass.cpp
JonasToth added a comment.
ping @alexfh what is your take on the issue?
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D48714
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
JonasToth added inline comments.
Comment at: test/clang-tidy/hicpp-exception-baseclass.cpp:191
+void templated_thrower() { throw T{}(); }
+// CHECK-MESSAGES: [[@LINE-1]]:34: warning: throwing an exception whose type
'int' is not derived from 'std::exception'
+
hokein added inline comments.
Comment at: test/clang-tidy/hicpp-exception-baseclass.cpp:191
+void templated_thrower() { throw T{}(); }
+// CHECK-MESSAGES: [[@LINE-1]]:34: warning: throwing an exception whose type
'int' is not derived from 'std::exception'
+
JonasToth added inline comments.
Comment at: test/clang-tidy/hicpp-exception-baseclass.cpp:191
+void templated_thrower() { throw T{}(); }
+// CHECK-MESSAGES: [[@LINE-1]]:34: warning: throwing an exception whose type
'int' is not derived from 'std::exception'
+
JonasToth updated this revision to Diff 160242.
JonasToth added a comment.
- update to current master of clang introduce CHECK-NOTES
- use new BeginLoc api
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D48714
Files:
clang-tidy/hicpp/ExceptionBaseclassCheck.cpp
JonasToth updated this revision to Diff 159099.
JonasToth added a comment.
- add better diagnostics about template instantiated exception types
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D48714
Files:
clang-tidy/hicpp/ExceptionBaseclassCheck.cpp
JonasToth added inline comments.
Comment at: test/clang-tidy/hicpp-exception-baseclass.cpp:191
+void templated_thrower() { throw T{}(); }
+// CHECK-MESSAGES: [[@LINE-1]]:34: warning: throwing an exception whose type
'int' is not derived from 'std::exception'
+
JonasToth updated this revision to Diff 158286.
JonasToth added a comment.
correct rebase.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D48714
Files:
clang-tidy/hicpp/ExceptionBaseclassCheck.cpp
test/clang-tidy/hicpp-exception-baseclass.cpp
Index:
JonasToth updated this revision to Diff 158284.
JonasToth added a comment.
Herald added subscribers: kbarton, mgorny, nemanjai.
rebase to master
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D48714
Files:
clang-tidy/cppcoreguidelines/CMakeLists.txt
JonasToth updated this revision to Diff 158282.
JonasToth added a comment.
rebase to master
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D48714
Files:
clang-tidy/hicpp/ExceptionBaseclassCheck.cpp
test/clang-tidy/hicpp-exception-baseclass.cpp
Index:
JonasToth added inline comments.
Comment at: test/clang-tidy/hicpp-exception-baseclass.cpp:191
+void templated_thrower() { throw T{}(); }
+// CHECK-MESSAGES: [[@LINE-1]]:34: warning: throwing an exception whose type
'int' is not derived from 'std::exception'
+
alexfh added inline comments.
Comment at: test/clang-tidy/hicpp-exception-baseclass.cpp:191
+void templated_thrower() { throw T{}(); }
+// CHECK-MESSAGES: [[@LINE-1]]:34: warning: throwing an exception whose type
'int' is not derived from 'std::exception'
+
hokein added inline comments.
Comment at: test/clang-tidy/hicpp-exception-baseclass.cpp:191
+void templated_thrower() { throw T{}(); }
+// CHECK-MESSAGES: [[@LINE-1]]:34: warning: throwing an exception whose type
'int' is not derived from 'std::exception'
+
I
JonasToth updated this revision to Diff 153280.
JonasToth added a comment.
- remove bad code snippet which was dead
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D48714
Files:
clang-tidy/hicpp/ExceptionBaseclassCheck.cpp
test/clang-tidy/hicpp-exception-baseclass.cpp
JonasToth created this revision.
JonasToth added reviewers: aaron.ballman, alexfh, hokein, ilya-biryukov.
Herald added subscribers: cfe-commits, xazax.hun.
JonasToth updated this revision to Diff 153280.
JonasToth added a comment.
- remove bad code snippet which was dead
PR37913 documents wrong
30 matches
Mail list logo
