This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rCXX336866: [libc++] Take 2: Replace uses of
_LIBCPP_ALWAYS_INLINE by… (authored by ldionne, committed by ).
Changed prior
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rL336866: [libc++] Take 2: Replace uses of
_LIBCPP_ALWAYS_INLINE by… (authored by ldionne, committed by ).
Changed prior
ldionne added a comment.
Pushing since I got an offline O.K. from Eric.
Repository:
rL LLVM
https://reviews.llvm.org/D48892
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ldionne added a comment.
I've now managed to run the `check-cxx-abilist` test on my machine and it
passes. I'd like to commit this again, @EricWF am I good to go?
Repository:
rL LLVM
https://reviews.llvm.org/D48892
___
cfe-commits mailing list
ldionne added inline comments.
Comment at: libcxx/include/streambuf:261
-_LIBCPP_ALWAYS_INLINE
+_LIBCPP_INLINE_VISIBILITY
void __pbump(streamsize __n) { __nout_ += __n; }
This one was marked as `_LIBCPP_EXTERN_TEMPLATE_INLINE_VISIBILITY` instead
ldionne updated this revision to Diff 154415.
ldionne added a comment.
This revision to the patch fixes a problem where __pbump had been applied
_LIBCPP_EXTERN_TEMPLATE_INLINE_VISIBILITY instead of _LIBCPP_INLINE_VISIBILITY,
which caused the symbols exported in the ABI to change and broke the CI.
On Thu, Jul 5, 2018 at 11:49 AM Davide Italiano via llvm-commits
wrote:
>
> On Thu, Jul 5, 2018 at 11:37 AM Duncan P. N. Exon Smith via
> Phabricator wrote:
> >
> > dexonsmith added a comment.
> >
> > In https://reviews.llvm.org/D48892#1153473, @davide wrote:
> >
> > > The lldb bot started
On Thu, Jul 5, 2018 at 11:37 AM Duncan P. N. Exon Smith via
Phabricator wrote:
>
> dexonsmith added a comment.
>
> In https://reviews.llvm.org/D48892#1153473, @davide wrote:
>
> > The lldb bot started failing very recently and the blamelist hints at this
> > change.
> >
> >
On Thu, Jul 5, 2018 at 11:46 AM Louis Dionne via Phabricator
wrote:
>
> ldionne added a comment.
>
> I reverted this commit. Sorry for the blunder. I'll take a look at why LLDB's
> tests are doing this.
>
No need to revert this immediately. I can probably take a look and fix
what the lldb tests
ldionne added a comment.
I reverted this commit. Sorry for the blunder. I'll take a look at why LLDB's
tests are doing this.
Repository:
rCXX libc++
https://reviews.llvm.org/D48892
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
dexonsmith added a comment.
In https://reviews.llvm.org/D48892#1153473, @davide wrote:
> The lldb bot started failing very recently and the blamelist hints at this
> change.
>
> http://green.lab.llvm.org/green/job/lldb-cmake//
>
> Can you please take a look?
>
> For your convenience, this
davide reopened this revision.
davide added a comment.
This revision is now accepted and ready to land.
The lldb bot started failing very recently and the blamelist hints at this
change.
http://green.lab.llvm.org/green/job/lldb-cmake//
Can you please take a look?
For your convenience,
This revision was automatically updated to reflect the committed changes.
Closed by commit rCXX336369: [libc++] Replace uses of _LIBCPP_ALWAYS_INLINE by
_LIBCPP_INLINE_VISIBILITY (authored by ldionne, committed by ).
Herald added a subscriber: cfe-commits.
Changed prior to commit:
13 matches
Mail list logo
