[PATCH] D48989: -fdebug-prefix-map option for cc1as

2018-07-10 Thread Paul Robinson via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC336685: Support -fdebug-prefix-map for assembler source (pass to cc1as). This (authored by probinson, committed by ). Changed prior to commit: https://reviews.llvm.org/D48989?vs=154669=154811#toc

[PATCH] D48989: -fdebug-prefix-map option for cc1as

2018-07-09 Thread Siddhartha Bagaria via Phabricator via cfe-commits
starsid updated this revision to Diff 154669. starsid marked an inline comment as done. starsid added a comment. Test improvements Repository: rC Clang https://reviews.llvm.org/D48989 Files: include/clang/Driver/Options.td lib/Driver/ToolChains/Clang.cpp test/Driver/debug-prefix-map.S

[PATCH] D48989: -fdebug-prefix-map option for cc1as

2018-07-09 Thread Paul Robinson via Phabricator via cfe-commits
probinson added a comment. In https://reviews.llvm.org/D48989#1153957, @starsid wrote: > In https://reviews.llvm.org/D48989#1153773, @compnerd wrote: > > > However, please add a test to ensure that the paths are mapped when > > invoking the assembler > > > I added the tests to check the mapping

[PATCH] D48989: -fdebug-prefix-map option for cc1as

2018-07-05 Thread Siddhartha Bagaria via Phabricator via cfe-commits
starsid added a comment. In https://reviews.llvm.org/D48989#1153773, @compnerd wrote: > However, please add a test to ensure that the paths are mapped when invoking > the assembler I added the tests to check the mapping logic through llvm-mc in https://reviews.llvm.org/D48988. In this

[PATCH] D48989: -fdebug-prefix-map option for cc1as

2018-07-05 Thread Siddhartha Bagaria via Phabricator via cfe-commits
starsid updated this revision to Diff 154354. starsid added a comment. add a test for the Driver passing the new flag Repository: rC Clang https://reviews.llvm.org/D48989 Files: include/clang/Driver/Options.td lib/Driver/ToolChains/Clang.cpp test/Driver/debug-prefix-map.S

[PATCH] D48989: -fdebug-prefix-map option for cc1as

2018-07-05 Thread Saleem Abdulrasool via Phabricator via cfe-commits
compnerd accepted this revision. compnerd added a comment. This revision is now accepted and ready to land. This seems reasonable if you need the support in the assembler. However, please add a test to ensure that the paths are mapped when invoking the assembler rather than the compiler.

[PATCH] D48989: -fdebug-prefix-map option for cc1as

2018-07-05 Thread Siddhartha Bagaria via Phabricator via cfe-commits
starsid updated this revision to Diff 154285. starsid added a comment. include generator input file for flag property change Repository: rC Clang https://reviews.llvm.org/D48989 Files: include/clang/Driver/Options.td lib/Driver/ToolChains/Clang.cpp tools/driver/cc1as_main.cpp Index:

[PATCH] D48989: -fdebug-prefix-map option for cc1as

2018-07-05 Thread Siddhartha Bagaria via Phabricator via cfe-commits
starsid created this revision. starsid added a reviewer: compnerd. Herald added a subscriber: cfe-commits. Depends on https://reviews.llvm.org/D48988. Repository: rC Clang https://reviews.llvm.org/D48989 Files: lib/Driver/ToolChains/Clang.cpp tools/driver/cc1as_main.cpp Index: